Commit 50ffba1b authored by Bob Moore's avatar Bob Moore Committed by Len Brown

ACPICA: Rename ACPI bit register access functions

Rename acpi_get_register and acpi_set_register to clarify the
purpose of these functions. New names are acpi_read_bit_register
and acpi_write_bit_register.
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLin Ming <ming.m.lin@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 9892dd23
...@@ -204,8 +204,8 @@ static acpi_status acpi_ev_fixed_event_initialize(void) ...@@ -204,8 +204,8 @@ static acpi_status acpi_ev_fixed_event_initialize(void)
if (acpi_gbl_fixed_event_info[i].enable_register_id != 0xFF) { if (acpi_gbl_fixed_event_info[i].enable_register_id != 0xFF) {
status = status =
acpi_set_register(acpi_gbl_fixed_event_info[i]. acpi_write_bit_register(acpi_gbl_fixed_event_info
enable_register_id, 0); [i].enable_register_id, 0);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return (status); return (status);
} }
...@@ -288,16 +288,16 @@ static u32 acpi_ev_fixed_event_dispatch(u32 event) ...@@ -288,16 +288,16 @@ static u32 acpi_ev_fixed_event_dispatch(u32 event)
/* Clear the status bit */ /* Clear the status bit */
(void)acpi_set_register(acpi_gbl_fixed_event_info[event]. (void)acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
status_register_id, 1); status_register_id, 1);
/* /*
* Make sure we've got a handler. If not, report an error. The event is * Make sure we've got a handler. If not, report an error. The event is
* disabled to prevent further interrupts. * disabled to prevent further interrupts.
*/ */
if (NULL == acpi_gbl_fixed_event_handlers[event].handler) { if (NULL == acpi_gbl_fixed_event_handlers[event].handler) {
(void)acpi_set_register(acpi_gbl_fixed_event_info[event]. (void)acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, 0); enable_register_id, 0);
ACPI_ERROR((AE_INFO, ACPI_ERROR((AE_INFO,
"No installed handler for fixed event [%08X]", "No installed handler for fixed event [%08X]",
......
...@@ -534,8 +534,8 @@ acpi_status acpi_ev_release_global_lock(void) ...@@ -534,8 +534,8 @@ acpi_status acpi_ev_release_global_lock(void)
*/ */
if (pending) { if (pending) {
status = status =
acpi_set_register(ACPI_BITREG_GLOBAL_LOCK_RELEASE, acpi_write_bit_register
1); (ACPI_BITREG_GLOBAL_LOCK_RELEASE, 1);
} }
ACPI_DEBUG_PRINT((ACPI_DB_EXEC, ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
......
...@@ -172,8 +172,8 @@ acpi_status acpi_enable_event(u32 event, u32 flags) ...@@ -172,8 +172,8 @@ acpi_status acpi_enable_event(u32 event, u32 flags)
* register bit) * register bit)
*/ */
status = status =
acpi_set_register(acpi_gbl_fixed_event_info[event]. acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, 1); enable_register_id, 1);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -181,8 +181,8 @@ acpi_status acpi_enable_event(u32 event, u32 flags) ...@@ -181,8 +181,8 @@ acpi_status acpi_enable_event(u32 event, u32 flags)
/* Make sure that the hardware responded */ /* Make sure that the hardware responded */
status = status =
acpi_get_register(acpi_gbl_fixed_event_info[event]. acpi_read_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, &value); enable_register_id, &value);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -354,15 +354,15 @@ acpi_status acpi_disable_event(u32 event, u32 flags) ...@@ -354,15 +354,15 @@ acpi_status acpi_disable_event(u32 event, u32 flags)
* register bit) * register bit)
*/ */
status = status =
acpi_set_register(acpi_gbl_fixed_event_info[event]. acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, 0); enable_register_id, 0);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
status = status =
acpi_get_register(acpi_gbl_fixed_event_info[event]. acpi_read_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, &value); enable_register_id, &value);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -407,8 +407,8 @@ acpi_status acpi_clear_event(u32 event) ...@@ -407,8 +407,8 @@ acpi_status acpi_clear_event(u32 event)
* register bit) * register bit)
*/ */
status = status =
acpi_set_register(acpi_gbl_fixed_event_info[event]. acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
status_register_id, 1); status_register_id, 1);
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -495,7 +495,7 @@ acpi_status acpi_get_event_status(u32 event, acpi_event_status * event_status) ...@@ -495,7 +495,7 @@ acpi_status acpi_get_event_status(u32 event, acpi_event_status * event_status)
/* Get the status of the requested fixed event */ /* Get the status of the requested fixed event */
status = status =
acpi_get_register(acpi_gbl_fixed_event_info[event]. acpi_read_bit_register(acpi_gbl_fixed_event_info[event].
enable_register_id, &value); enable_register_id, &value);
if (ACPI_FAILURE(status)) if (ACPI_FAILURE(status))
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
...@@ -503,7 +503,7 @@ acpi_status acpi_get_event_status(u32 event, acpi_event_status * event_status) ...@@ -503,7 +503,7 @@ acpi_status acpi_get_event_status(u32 event, acpi_event_status * event_status)
*event_status = value; *event_status = value;
status = status =
acpi_get_register(acpi_gbl_fixed_event_info[event]. acpi_read_bit_register(acpi_gbl_fixed_event_info[event].
status_register_id, &value); status_register_id, &value);
if (ACPI_FAILURE(status)) if (ACPI_FAILURE(status))
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
......
...@@ -172,7 +172,7 @@ u32 acpi_hw_get_mode(void) ...@@ -172,7 +172,7 @@ u32 acpi_hw_get_mode(void)
return_UINT32(ACPI_SYS_MODE_ACPI); return_UINT32(ACPI_SYS_MODE_ACPI);
} }
status = acpi_get_register(ACPI_BITREG_SCI_ENABLE, &value); status = acpi_read_bit_register(ACPI_BITREG_SCI_ENABLE, &value);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_UINT32(ACPI_SYS_MODE_LEGACY); return_UINT32(ACPI_SYS_MODE_LEGACY);
} }
......
...@@ -250,7 +250,7 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state) ...@@ -250,7 +250,7 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
/* Clear wake status */ /* Clear wake status */
status = acpi_set_register(ACPI_BITREG_WAKE_STATUS, 1); status = acpi_write_bit_register(ACPI_BITREG_WAKE_STATUS, 1);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -365,7 +365,7 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state) ...@@ -365,7 +365,7 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
/* Wait until we enter sleep state */ /* Wait until we enter sleep state */
do { do {
status = acpi_get_register(ACPI_BITREG_WAKE_STATUS, status = acpi_read_bit_register(ACPI_BITREG_WAKE_STATUS,
&in_value); &in_value);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
...@@ -399,7 +399,7 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void) ...@@ -399,7 +399,7 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
ACPI_FUNCTION_TRACE(acpi_enter_sleep_state_s4bios); ACPI_FUNCTION_TRACE(acpi_enter_sleep_state_s4bios);
status = acpi_set_register(ACPI_BITREG_WAKE_STATUS, 1); status = acpi_write_bit_register(ACPI_BITREG_WAKE_STATUS, 1);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -431,7 +431,8 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void) ...@@ -431,7 +431,8 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
do { do {
acpi_os_stall(1000); acpi_os_stall(1000);
status = acpi_get_register(ACPI_BITREG_WAKE_STATUS, &in_value); status =
acpi_read_bit_register(ACPI_BITREG_WAKE_STATUS, &in_value);
if (ACPI_FAILURE(status)) { if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
...@@ -592,18 +593,18 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state) ...@@ -592,18 +593,18 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
* it to determine whether the system is rebooting or resuming. Clear * it to determine whether the system is rebooting or resuming. Clear
* it for compatibility. * it for compatibility.
*/ */
acpi_set_register(ACPI_BITREG_WAKE_STATUS, 1); acpi_write_bit_register(ACPI_BITREG_WAKE_STATUS, 1);
acpi_gbl_system_awake_and_running = TRUE; acpi_gbl_system_awake_and_running = TRUE;
/* Enable power button */ /* Enable power button */
(void) (void)
acpi_set_register(acpi_gbl_fixed_event_info acpi_write_bit_register(acpi_gbl_fixed_event_info
[ACPI_EVENT_POWER_BUTTON].enable_register_id, 1); [ACPI_EVENT_POWER_BUTTON].enable_register_id, 1);
(void) (void)
acpi_set_register(acpi_gbl_fixed_event_info acpi_write_bit_register(acpi_gbl_fixed_event_info
[ACPI_EVENT_POWER_BUTTON].status_register_id, 1); [ACPI_EVENT_POWER_BUTTON].status_register_id, 1);
arg.integer.value = ACPI_SST_WORKING; arg.integer.value = ACPI_SST_WORKING;
......
...@@ -242,7 +242,7 @@ ACPI_EXPORT_SYMBOL(acpi_write) ...@@ -242,7 +242,7 @@ ACPI_EXPORT_SYMBOL(acpi_write)
/******************************************************************************* /*******************************************************************************
* *
* FUNCTION: acpi_get_register * FUNCTION: acpi_read_bit_register
* *
* PARAMETERS: register_id - ID of ACPI Bit Register to access * PARAMETERS: register_id - ID of ACPI Bit Register to access
* return_value - Value that was read from the register, * return_value - Value that was read from the register,
...@@ -264,13 +264,13 @@ ACPI_EXPORT_SYMBOL(acpi_write) ...@@ -264,13 +264,13 @@ ACPI_EXPORT_SYMBOL(acpi_write)
* it make much sense to actually read this field.) * it make much sense to actually read this field.)
* *
******************************************************************************/ ******************************************************************************/
acpi_status acpi_get_register(u32 register_id, u32 *return_value) acpi_status acpi_read_bit_register(u32 register_id, u32 *return_value)
{ {
u32 register_value = 0; u32 register_value = 0;
struct acpi_bit_register_info *bit_reg_info; struct acpi_bit_register_info *bit_reg_info;
acpi_status status; acpi_status status;
ACPI_FUNCTION_TRACE(acpi_get_register); ACPI_FUNCTION_TRACE(acpi_read_bit_register);
/* Get the info structure corresponding to the requested ACPI Register */ /* Get the info structure corresponding to the requested ACPI Register */
...@@ -302,11 +302,11 @@ acpi_status acpi_get_register(u32 register_id, u32 *return_value) ...@@ -302,11 +302,11 @@ acpi_status acpi_get_register(u32 register_id, u32 *return_value)
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
ACPI_EXPORT_SYMBOL(acpi_get_register) ACPI_EXPORT_SYMBOL(acpi_read_bit_register)
/******************************************************************************* /*******************************************************************************
* *
* FUNCTION: acpi_set_register * FUNCTION: acpi_write_bit_register
* *
* PARAMETERS: register_id - ID of ACPI Bit Register to access * PARAMETERS: register_id - ID of ACPI Bit Register to access
* Value - Value to write to the register, in bit * Value - Value to write to the register, in bit
...@@ -322,14 +322,14 @@ ACPI_EXPORT_SYMBOL(acpi_get_register) ...@@ -322,14 +322,14 @@ ACPI_EXPORT_SYMBOL(acpi_get_register)
* PM2 Control. * PM2 Control.
* *
******************************************************************************/ ******************************************************************************/
acpi_status acpi_set_register(u32 register_id, u32 value) acpi_status acpi_write_bit_register(u32 register_id, u32 value)
{ {
u32 register_value = 0; u32 register_value = 0;
struct acpi_bit_register_info *bit_reg_info; struct acpi_bit_register_info *bit_reg_info;
acpi_status status; acpi_status status;
acpi_cpu_flags lock_flags; acpi_cpu_flags lock_flags;
ACPI_FUNCTION_TRACE_U32(acpi_set_register, register_id); ACPI_FUNCTION_TRACE_U32(acpi_write_bit_register, register_id);
/* Get the info structure corresponding to the requested ACPI Register */ /* Get the info structure corresponding to the requested ACPI Register */
...@@ -459,7 +459,7 @@ acpi_status acpi_set_register(u32 register_id, u32 value) ...@@ -459,7 +459,7 @@ acpi_status acpi_set_register(u32 register_id, u32 value)
return_ACPI_STATUS(status); return_ACPI_STATUS(status);
} }
ACPI_EXPORT_SYMBOL(acpi_set_register) ACPI_EXPORT_SYMBOL(acpi_write_bit_register)
/******************************************************************************* /*******************************************************************************
* *
......
...@@ -630,7 +630,7 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr, ...@@ -630,7 +630,7 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
* In either case, the proper way to * In either case, the proper way to
* handle BM_RLD is to set it and leave it set. * handle BM_RLD is to set it and leave it set.
*/ */
acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 1); acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, 1);
return; return;
} }
...@@ -800,9 +800,9 @@ static int acpi_idle_bm_check(void) ...@@ -800,9 +800,9 @@ static int acpi_idle_bm_check(void)
{ {
u32 bm_status = 0; u32 bm_status = 0;
acpi_get_register(ACPI_BITREG_BUS_MASTER_STATUS, &bm_status); acpi_read_bit_register(ACPI_BITREG_BUS_MASTER_STATUS, &bm_status);
if (bm_status) if (bm_status)
acpi_set_register(ACPI_BITREG_BUS_MASTER_STATUS, 1); acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_STATUS, 1);
/* /*
* PIIX4 Erratum #18: Note that BM_STS doesn't always reflect * PIIX4 Erratum #18: Note that BM_STS doesn't always reflect
* the true state of bus mastering activity; forcing us to * the true state of bus mastering activity; forcing us to
...@@ -1028,7 +1028,7 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev, ...@@ -1028,7 +1028,7 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
c3_cpu_count++; c3_cpu_count++;
/* Disable bus master arbitration when all CPUs are in C3 */ /* Disable bus master arbitration when all CPUs are in C3 */
if (c3_cpu_count == num_online_cpus()) if (c3_cpu_count == num_online_cpus())
acpi_set_register(ACPI_BITREG_ARB_DISABLE, 1); acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 1);
spin_unlock(&c3_lock); spin_unlock(&c3_lock);
} else if (!pr->flags.bm_check) { } else if (!pr->flags.bm_check) {
ACPI_FLUSH_CPU_CACHE(); ACPI_FLUSH_CPU_CACHE();
...@@ -1041,7 +1041,7 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev, ...@@ -1041,7 +1041,7 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
/* Re-enable bus master arbitration */ /* Re-enable bus master arbitration */
if (pr->flags.bm_check && pr->flags.bm_control) { if (pr->flags.bm_check && pr->flags.bm_control) {
spin_lock(&c3_lock); spin_lock(&c3_lock);
acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0); acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 0);
c3_cpu_count--; c3_cpu_count--;
spin_unlock(&c3_lock); spin_unlock(&c3_lock);
} }
......
...@@ -248,7 +248,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) ...@@ -248,7 +248,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
/* If ACPI is not enabled by the BIOS, we need to enable it here. */ /* If ACPI is not enabled by the BIOS, we need to enable it here. */
if (set_sci_en_on_resume) if (set_sci_en_on_resume)
acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1); acpi_write_bit_register(ACPI_BITREG_SCI_ENABLE, 1);
else else
acpi_enable(); acpi_enable();
......
...@@ -345,9 +345,9 @@ acpi_resource_to_address64(struct acpi_resource *resource, ...@@ -345,9 +345,9 @@ acpi_resource_to_address64(struct acpi_resource *resource,
*/ */
acpi_status acpi_reset(void); acpi_status acpi_reset(void);
acpi_status acpi_get_register(u32 register_id, u32 * return_value); acpi_status acpi_read_bit_register(u32 register_id, u32 *return_value);
acpi_status acpi_set_register(u32 register_id, u32 value); acpi_status acpi_write_bit_register(u32 register_id, u32 value);
acpi_status acpi_set_firmware_waking_vector(u32 physical_address); acpi_status acpi_set_firmware_waking_vector(u32 physical_address);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment