Commit 5111e749 authored by Suzuki K Poulose's avatar Suzuki K Poulose Committed by Greg Kroah-Hartman

coresight: platform: Fix leaking device reference

We don't drop the reference on the remote device while parsing the
connection, held by bus_find_device(). Fix this by duplicating the
device name and dropping the reference.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a0f9992c
...@@ -162,7 +162,9 @@ static int of_coresight_parse_endpoint(struct device *dev, ...@@ -162,7 +162,9 @@ static int of_coresight_parse_endpoint(struct device *dev,
} }
pdata->outports[i] = endpoint.port; pdata->outports[i] = endpoint.port;
pdata->child_names[i] = dev_name(rdev); pdata->child_names[i] = devm_kstrdup(dev,
dev_name(rdev),
GFP_KERNEL);
pdata->child_ports[i] = rendpoint.id; pdata->child_ports[i] = rendpoint.id;
/* Connection record updated */ /* Connection record updated */
ret = 1; ret = 1;
...@@ -172,6 +174,8 @@ static int of_coresight_parse_endpoint(struct device *dev, ...@@ -172,6 +174,8 @@ static int of_coresight_parse_endpoint(struct device *dev,
of_node_put(rparent); of_node_put(rparent);
if (rport) if (rport)
of_node_put(rport); of_node_put(rport);
if (rdev)
put_device(rdev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment