Commit 5228e39e authored by Stanimir Varbanov's avatar Stanimir Varbanov Committed by Bjorn Helgaas

PCI: designware: Remove incorrect io_base assignment

"pp->io" is an I/O resource, e.g., "[io 0x0000-0xffff]"; "pp->io_base" is
the CPU physical address of a region where the host bridge converts CPU
memory accesses into PCI I/O transactions.

Corrupting pp->io_base by assigning pp->io->start to it breaks access to
the PCI I/O space, as reported by Kishon.

Remove the invalid assignment.

[bhelgaas: changelog]
Fixes: 0021d22b ("PCI: designware: Use of_pci_get_host_bridge_resources() to parse DT")
Reported-and-tested-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 3dcc8d39
...@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) ...@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
ret, pp->io); ret, pp->io);
continue; continue;
} }
pp->io_base = pp->io->start;
break; break;
case IORESOURCE_MEM: case IORESOURCE_MEM:
pp->mem = win->res; pp->mem = win->res;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment