Commit 52a44f83 authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Ingo Molnar

perf/core: Fix the address filtering fix

The following recent commit:

  c60f83b8 ("perf, pt, coresight: Fix address filters for vmas with non-zero offset")

changes the address filtering logic to communicate filter ranges to the PMU driver
via a single address range object, instead of having the driver do the final bit of
math.

That change forgets to take into account kernel filters, which are not calculated
the same way as DSO based filters.

Fix that by passing the kernel filters the same way as file-based filters.
This doesn't require any additional changes in the drivers.
Reported-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Fixes: c60f83b8 ("perf, pt, coresight: Fix address filters for vmas with non-zero offset")
Link: https://lkml.kernel.org/r/20190329091212.29870-1-alexander.shishkin@linux.intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 5f843ed4
...@@ -9077,26 +9077,29 @@ static void perf_event_addr_filters_apply(struct perf_event *event) ...@@ -9077,26 +9077,29 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
if (task == TASK_TOMBSTONE) if (task == TASK_TOMBSTONE)
return; return;
if (!ifh->nr_file_filters) if (ifh->nr_file_filters) {
return; mm = get_task_mm(event->ctx->task);
if (!mm)
mm = get_task_mm(event->ctx->task); goto restart;
if (!mm)
goto restart;
down_read(&mm->mmap_sem); down_read(&mm->mmap_sem);
}
raw_spin_lock_irqsave(&ifh->lock, flags); raw_spin_lock_irqsave(&ifh->lock, flags);
list_for_each_entry(filter, &ifh->list, entry) { list_for_each_entry(filter, &ifh->list, entry) {
event->addr_filter_ranges[count].start = 0; if (filter->path.dentry) {
event->addr_filter_ranges[count].size = 0; /*
* Adjust base offset if the filter is associated to a
* binary that needs to be mapped:
*/
event->addr_filter_ranges[count].start = 0;
event->addr_filter_ranges[count].size = 0;
/*
* Adjust base offset if the filter is associated to a binary
* that needs to be mapped:
*/
if (filter->path.dentry)
perf_addr_filter_apply(filter, mm, &event->addr_filter_ranges[count]); perf_addr_filter_apply(filter, mm, &event->addr_filter_ranges[count]);
} else {
event->addr_filter_ranges[count].start = filter->offset;
event->addr_filter_ranges[count].size = filter->size;
}
count++; count++;
} }
...@@ -9104,9 +9107,11 @@ static void perf_event_addr_filters_apply(struct perf_event *event) ...@@ -9104,9 +9107,11 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
event->addr_filters_gen++; event->addr_filters_gen++;
raw_spin_unlock_irqrestore(&ifh->lock, flags); raw_spin_unlock_irqrestore(&ifh->lock, flags);
up_read(&mm->mmap_sem); if (ifh->nr_file_filters) {
up_read(&mm->mmap_sem);
mmput(mm); mmput(mm);
}
restart: restart:
perf_event_stop(event, 1); perf_event_stop(event, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment