Commit 533763d3 authored by Martin Gebert's avatar Martin Gebert Committed by Jeff Garzik

[netdrvr] au1000_eth: Spinlock initialisation fix

Seems like the spinlock for the AU1x00 ethernet device is initialised too
late, as it is already used in enable_mac(), which is called via
mii_probe() before the init takes place.

The attached patch is working here for a Linux Au1100 2.6.22.6 kernel,
and as far as I checked should also be applicable to the current head
(just line numbers differ).
Signed-off-by: default avatarMartin Gebert <Martin.Gebert@alpha-bit.de>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 894d6276
...@@ -653,6 +653,8 @@ static struct net_device * au1000_probe(int port_num) ...@@ -653,6 +653,8 @@ static struct net_device * au1000_probe(int port_num)
aup = dev->priv; aup = dev->priv;
spin_lock_init(&aup->lock);
/* Allocate the data buffers */ /* Allocate the data buffers */
/* Snooping works fine with eth on all au1xxx */ /* Snooping works fine with eth on all au1xxx */
aup->vaddr = (u32)dma_alloc_noncoherent(NULL, MAX_BUF_SIZE * aup->vaddr = (u32)dma_alloc_noncoherent(NULL, MAX_BUF_SIZE *
...@@ -753,7 +755,6 @@ static struct net_device * au1000_probe(int port_num) ...@@ -753,7 +755,6 @@ static struct net_device * au1000_probe(int port_num)
aup->tx_db_inuse[i] = pDB; aup->tx_db_inuse[i] = pDB;
} }
spin_lock_init(&aup->lock);
dev->base_addr = base; dev->base_addr = base;
dev->irq = irq; dev->irq = irq;
dev->open = au1000_open; dev->open = au1000_open;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment