Commit 54e98b5d authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

net: dsa: b53: Turn off Broadcom tags for more switches

Models such as BCM5395/97/98 and BCM53125/24/53115 and compatible require that
we turn on managed mode to actually act on Broadcom tags, otherwise they just
pass them through on ingress (host -> switch) and don't insert them in egress
(switch -> host). Turning on managed mode is simple, but requires us to
properly support ARL misses on multicast addresses which is a much more
involved set of changes not suitable for a bug fix for this release.
Reported-by: default avatarJochen Friedrich <jochen@scram.de>
Fixes: 7edc58d6 ("net: dsa: b53: Turn on Broadcom tags")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 820d1d5e
...@@ -1500,10 +1500,13 @@ static enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, ...@@ -1500,10 +1500,13 @@ static enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds,
{ {
struct b53_device *dev = ds->priv; struct b53_device *dev = ds->priv;
/* Older models support a different tag format that we do not /* Older models (5325, 5365) support a different tag format that we do
* support in net/dsa/tag_brcm.c yet. * not support in net/dsa/tag_brcm.c yet. 539x and 531x5 require managed
* mode to be turned on which means we need to specifically manage ARL
* misses on multicast addresses (TBD).
*/ */
if (is5325(dev) || is5365(dev) || !b53_can_enable_brcm_tags(ds, port)) if (is5325(dev) || is5365(dev) || is539x(dev) || is531x5(dev) ||
!b53_can_enable_brcm_tags(ds, port))
return DSA_TAG_PROTO_NONE; return DSA_TAG_PROTO_NONE;
/* Broadcom BCM58xx chips have a flow accelerator on Port 8 /* Broadcom BCM58xx chips have a flow accelerator on Port 8
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment