Commit 55a92a2b authored by Adam Kropelin's avatar Adam Kropelin Committed by David S. Miller

[FB]: Fix uninitialized fb_cmap member in sbuslib.c

When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
which quickly leads to an oops when fb_set_cmap() dereferences it.

First encountered in Aurora Wombat kernels and seems to afflict mainline
as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
anything to display on my CG6, but at least it no longer oopses the kernel.
Signed-off-by: default avatarAdam Kropelin <akropel1@rochester.rr.com>
Signed-off-by: default avatarDavid S. Miller <davem@redhat.com>
parent 31c577a1
...@@ -122,6 +122,7 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg, ...@@ -122,6 +122,7 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg,
cmap.red = &red; cmap.red = &red;
cmap.green = &green; cmap.green = &green;
cmap.blue = &blue; cmap.blue = &blue;
cmap.transp = NULL;
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
int err; int err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment