Commit 57635e47 authored by Johan Hovold's avatar Johan Hovold Committed by Ben Hutchings

mceusb: fix NULL-deref at probe

commit 03eb2a55 upstream.

Make sure to check for the required out endpoint to avoid dereferencing
a NULL-pointer in mce_request_packet should a malicious device lack such
an endpoint. Note that this path is hit during probe.

Fixes: 66e89522 ("V4L/DVB: IR: add mceusb IR receiver driver")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
[bwh: Backported to 3.2: using mce_dbg() instead of dev_dbg()]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent c4c69518
......@@ -1301,8 +1301,8 @@ static int __devinit mceusb_dev_probe(struct usb_interface *intf,
"found\n");
}
}
if (ep_in == NULL) {
mce_dbg(&intf->dev, "inbound and/or endpoint not found\n");
if (!ep_in || !ep_out) {
mce_dbg(&intf->dev, "required endpoints not found\n");
return -ENODEV;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment