Commit 578620f4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Theodore Ts'o

ext4: return -ENOMEM instead of success

We should set the error code if kzalloc() fails.

Fixes: 67cf5b09 ("ext4: add the basic function for inline data support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
parent 7e6e1ef4
...@@ -341,8 +341,10 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode, ...@@ -341,8 +341,10 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode,
len -= EXT4_MIN_INLINE_DATA_SIZE; len -= EXT4_MIN_INLINE_DATA_SIZE;
value = kzalloc(len, GFP_NOFS); value = kzalloc(len, GFP_NOFS);
if (!value) if (!value) {
error = -ENOMEM;
goto out; goto out;
}
error = ext4_xattr_ibody_get(inode, i.name_index, i.name, error = ext4_xattr_ibody_get(inode, i.name_index, i.name,
value, len); value, len);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment