Commit 5b2cd0d1 authored by Steven Rostedt (Red Hat)'s avatar Steven Rostedt (Red Hat) Committed by Kamal Mostafa

tracing: Fix trace_printk() to print when not using bprintk()

commit 3debb0a9 upstream.

The trace_printk() code will allocate extra buffers if the compile detects
that a trace_printk() is used. To do this, the format of the trace_printk()
is saved to the __trace_printk_fmt section, and if that section is bigger
than zero, the buffers are allocated (along with a message that this has
happened).

If trace_printk() uses a format that is not a constant, and thus something
not guaranteed to be around when the print happens, the compiler optimizes
the fmt out, as it is not used, and the __trace_printk_fmt section is not
filled. This means the kernel will not allocate the special buffers needed
for the trace_printk() and the trace_printk() will not write anything to the
tracing buffer.

Adding a "__used" to the variable in the __trace_printk_fmt section will
keep it around, even though it is set to NULL. This will keep the string
from being printed in the debugfs/tracing/printk_formats section as it is
not needed.
Reported-by: default avatarVlastimil Babka <vbabka@suse.cz>
Fixes: 07d777fe "tracing: Add percpu buffers for trace_printk()"
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 5b720cc9
...@@ -605,7 +605,7 @@ do { \ ...@@ -605,7 +605,7 @@ do { \
#define do_trace_printk(fmt, args...) \ #define do_trace_printk(fmt, args...) \
do { \ do { \
static const char *trace_printk_fmt \ static const char *trace_printk_fmt __used \
__attribute__((section("__trace_printk_fmt"))) = \ __attribute__((section("__trace_printk_fmt"))) = \
__builtin_constant_p(fmt) ? fmt : NULL; \ __builtin_constant_p(fmt) ? fmt : NULL; \
\ \
...@@ -649,7 +649,7 @@ int __trace_printk(unsigned long ip, const char *fmt, ...); ...@@ -649,7 +649,7 @@ int __trace_printk(unsigned long ip, const char *fmt, ...);
*/ */
#define trace_puts(str) ({ \ #define trace_puts(str) ({ \
static const char *trace_printk_fmt \ static const char *trace_printk_fmt __used \
__attribute__((section("__trace_printk_fmt"))) = \ __attribute__((section("__trace_printk_fmt"))) = \
__builtin_constant_p(str) ? str : NULL; \ __builtin_constant_p(str) ? str : NULL; \
\ \
...@@ -671,7 +671,7 @@ extern void trace_dump_stack(int skip); ...@@ -671,7 +671,7 @@ extern void trace_dump_stack(int skip);
#define ftrace_vprintk(fmt, vargs) \ #define ftrace_vprintk(fmt, vargs) \
do { \ do { \
if (__builtin_constant_p(fmt)) { \ if (__builtin_constant_p(fmt)) { \
static const char *trace_printk_fmt \ static const char *trace_printk_fmt __used \
__attribute__((section("__trace_printk_fmt"))) = \ __attribute__((section("__trace_printk_fmt"))) = \
__builtin_constant_p(fmt) ? fmt : NULL; \ __builtin_constant_p(fmt) ? fmt : NULL; \
\ \
......
...@@ -290,6 +290,9 @@ static int t_show(struct seq_file *m, void *v) ...@@ -290,6 +290,9 @@ static int t_show(struct seq_file *m, void *v)
const char *str = *fmt; const char *str = *fmt;
int i; int i;
if (!*fmt)
return 0;
seq_printf(m, "0x%lx : \"", *(unsigned long *)fmt); seq_printf(m, "0x%lx : \"", *(unsigned long *)fmt);
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment