Commit 5da61209 authored by Jules Irenge's avatar Jules Irenge Committed by Felix Fietkau

mt76: remove unnecessary annotations

Sparse report warnings at mt76_tx_status_unlock() and mt76_tx_status_lock()

warning: context imbalance in mt76_tx_status_lock() - wrong count at exit
warning: context imbalance in mt76_tx_status_unlock() - unexpected unlock

The root cause is the additional __acquire(&dev->status_list.lock)
and __release(&dev->status_list.unlock) called
 from inside mt76_tx_status_lock() and mt76_tx_status_unlock().

Remove __acquire(&dev->status_list.lock) annotation
Remove __releases(&dev->status_list.unlock)
Correct &dev->status_list.unlock to &dev->status_list.lock
	-unlock not defined in the sk_buff_head struct
Signed-off-by: default avatarJules Irenge <jbi.octave@gmail.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 9fbb4b86
...@@ -101,19 +101,17 @@ mt76_tx_status_lock(struct mt76_dev *dev, struct sk_buff_head *list) ...@@ -101,19 +101,17 @@ mt76_tx_status_lock(struct mt76_dev *dev, struct sk_buff_head *list)
{ {
__skb_queue_head_init(list); __skb_queue_head_init(list);
spin_lock_bh(&dev->status_list.lock); spin_lock_bh(&dev->status_list.lock);
__acquire(&dev->status_list.lock);
} }
EXPORT_SYMBOL_GPL(mt76_tx_status_lock); EXPORT_SYMBOL_GPL(mt76_tx_status_lock);
void void
mt76_tx_status_unlock(struct mt76_dev *dev, struct sk_buff_head *list) mt76_tx_status_unlock(struct mt76_dev *dev, struct sk_buff_head *list)
__releases(&dev->status_list.unlock) __releases(&dev->status_list.lock)
{ {
struct ieee80211_hw *hw; struct ieee80211_hw *hw;
struct sk_buff *skb; struct sk_buff *skb;
spin_unlock_bh(&dev->status_list.lock); spin_unlock_bh(&dev->status_list.lock);
__release(&dev->status_list.unlock);
while ((skb = __skb_dequeue(list)) != NULL) { while ((skb = __skb_dequeue(list)) != NULL) {
hw = mt76_tx_status_get_hw(dev, skb); hw = mt76_tx_status_get_hw(dev, skb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment