Commit 602d38bc authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Bjorn Helgaas

PCI: dra7xx: Simplify probe code with devm_gpiod_get_optional()

No functional change.  Use the new devm_gpiod_get_optional() to simplify
the probe code.
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 950bf638
...@@ -320,9 +320,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) ...@@ -320,9 +320,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node; struct device_node *np = dev->of_node;
char name[10]; char name[10];
int gpio_sel; struct gpio_desc *reset;
enum of_gpio_flags flags;
unsigned long gpio_flags;
dra7xx = devm_kzalloc(dev, sizeof(*dra7xx), GFP_KERNEL); dra7xx = devm_kzalloc(dev, sizeof(*dra7xx), GFP_KERNEL);
if (!dra7xx) if (!dra7xx)
...@@ -388,19 +386,10 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) ...@@ -388,19 +386,10 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
goto err_get_sync; goto err_get_sync;
} }
gpio_sel = of_get_gpio_flags(dev->of_node, 0, &flags); reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);
if (gpio_is_valid(gpio_sel)) { if (IS_ERR(reset)) {
gpio_flags = (flags & OF_GPIO_ACTIVE_LOW) ? ret = PTR_ERR(reset);
GPIOF_OUT_INIT_LOW : GPIOF_OUT_INIT_HIGH; dev_err(&pdev->dev, "gpio request failed, ret %d\n", ret);
ret = devm_gpio_request_one(dev, gpio_sel, gpio_flags,
"pcie_reset");
if (ret) {
dev_err(dev, "gpio%d request failed, ret %d\n",
gpio_sel, ret);
goto err_gpio;
}
} else if (gpio_sel == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
goto err_gpio; goto err_gpio;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment