perf tools: Leave DSO destruction to the map destruction

As the way DSOs are created are normally via dsos__findnew, so that we
don't have to load the same dso multiple times for multiple maps (think
about /lib64/libc.so.6), so they may be shared and dso__delete() should
be left to be done as part of the map destruction process.

This will all be properly solved by reference counting struct dso, which
will be done soon.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-gbrohe1nvkjxw3u5a1bgj3yh@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0170b14f
...@@ -195,7 +195,6 @@ static void put_target_map(struct map *map, bool user) ...@@ -195,7 +195,6 @@ static void put_target_map(struct map *map, bool user)
{ {
if (map && user) { if (map && user) {
/* Only the user map needs to be released */ /* Only the user map needs to be released */
dso__delete(map->dso);
map__delete(map); map__delete(map);
} }
} }
...@@ -1791,7 +1790,6 @@ static int find_perf_probe_point_from_map(struct probe_trace_point *tp, ...@@ -1791,7 +1790,6 @@ static int find_perf_probe_point_from_map(struct probe_trace_point *tp,
out: out:
if (map && !is_kprobe) { if (map && !is_kprobe) {
dso__delete(map->dso);
map__delete(map); map__delete(map);
} }
...@@ -2884,7 +2882,6 @@ int show_available_funcs(const char *target, struct strfilter *_filter, ...@@ -2884,7 +2882,6 @@ int show_available_funcs(const char *target, struct strfilter *_filter,
dso__fprintf_symbols_by_name(map->dso, map->type, stdout); dso__fprintf_symbols_by_name(map->dso, map->type, stdout);
end: end:
if (user) { if (user) {
dso__delete(map->dso);
map__delete(map); map__delete(map);
} }
exit_symbol_maps(); exit_symbol_maps();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment