Commit 61fbad6a authored by Luis de Bethencourt's avatar Luis de Bethencourt Committed by Greg Kroah-Hartman

mvsas: fix misleading indentation

commit 7789cd39 upstream.

Fix a smatch warning:
drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended?

The code is correct, the indention is misleading. When the device is not
ready we want to return SAS_PHY_DOWN. But current indentation makes it
look like we only do so in the else branch of if (mvi_dev).
Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 72ca0ab3
...@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf ...@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
mv_dprintk("device %016llx not ready.\n", mv_dprintk("device %016llx not ready.\n",
SAS_ADDR(dev->sas_addr)); SAS_ADDR(dev->sas_addr));
rc = SAS_PHY_DOWN; rc = SAS_PHY_DOWN;
return rc; return rc;
} }
tei.port = dev->port->lldd_port; tei.port = dev->port->lldd_port;
if (tei.port && !tei.port->port_attached && !tmf) { if (tei.port && !tei.port->port_attached && !tmf) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment