Commit 633caba8 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman

tty: Move tty hung up check from port->lock critical section

The port->lock does not protect the filp->f_op field; move
the tty_hung_up_p() test outside the port->lock critical section
in tty_port_close_start().
Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 19038ad9
...@@ -473,12 +473,10 @@ int tty_port_close_start(struct tty_port *port, ...@@ -473,12 +473,10 @@ int tty_port_close_start(struct tty_port *port,
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&port->lock, flags); if (tty_hung_up_p(filp))
if (tty_hung_up_p(filp)) {
spin_unlock_irqrestore(&port->lock, flags);
return 0; return 0;
}
spin_lock_irqsave(&port->lock, flags);
if (tty->count == 1 && port->count != 1) { if (tty->count == 1 && port->count != 1) {
printk(KERN_WARNING printk(KERN_WARNING
"tty_port_close_start: tty->count = 1 port count = %d.\n", "tty_port_close_start: tty->count = 1 port count = %d.\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment