Commit 63880b23 authored by Bjorn Helgaas's avatar Bjorn Helgaas

PCI: Ignore BAR updates on virtual functions

VF BARs are read-only zero, so updating VF BARs will not have any effect.
See the SR-IOV spec r1.1, sec 3.4.1.11.

We already ignore these updates because of 70675e0b ("PCI: Don't try to
restore VF BARs"); this merely restructures it slightly to make it easier
to split updates for standard and SR-IOV BARs.
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
parent f40ec3c7
...@@ -564,10 +564,6 @@ static void pci_restore_bars(struct pci_dev *dev) ...@@ -564,10 +564,6 @@ static void pci_restore_bars(struct pci_dev *dev)
{ {
int i; int i;
/* Per SR-IOV spec 3.4.1.11, VF BARs are RO zero */
if (dev->is_virtfn)
return;
for (i = 0; i < PCI_BRIDGE_RESOURCES; i++) for (i = 0; i < PCI_BRIDGE_RESOURCES; i++)
pci_update_resource(dev, i); pci_update_resource(dev, i);
} }
......
...@@ -36,10 +36,9 @@ void pci_update_resource(struct pci_dev *dev, int resno) ...@@ -36,10 +36,9 @@ void pci_update_resource(struct pci_dev *dev, int resno)
enum pci_bar_type type; enum pci_bar_type type;
struct resource *res = dev->resource + resno; struct resource *res = dev->resource + resno;
if (dev->is_virtfn) { /* Per SR-IOV spec 3.4.1.11, VF BARs are RO zero */
dev_warn(&dev->dev, "can't update VF BAR%d\n", resno); if (dev->is_virtfn)
return; return;
}
/* /*
* Ignore resources for unimplemented BARs and unused resource slots * Ignore resources for unimplemented BARs and unused resource slots
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment