Commit 65f2767a authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

net: phy: Add missing driver check in phy_aneg_done()

Dan's static checker caught a potential code path in phy_state_machine() where
we were not checking phydev->drv which is in phy_aneg_done().
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 25149ef9 ("net: phy: Check phydev->drv")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e37d691
...@@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts) ...@@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts)
*/ */
int phy_aneg_done(struct phy_device *phydev) int phy_aneg_done(struct phy_device *phydev)
{ {
if (phydev->drv->aneg_done) if (phydev->drv && phydev->drv->aneg_done)
return phydev->drv->aneg_done(phydev); return phydev->drv->aneg_done(phydev);
return genphy_aneg_done(phydev); return genphy_aneg_done(phydev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment