Commit 65fac406 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Kamal Mostafa

nfsd: fix deadlock secinfo+readdir compound

commit 2f6fc056 upstream.

nfsd_lookup_dentry exits with the parent filehandle locked.  fh_put also
unlocks if necessary (nfsd filehandle locking is probably too lenient),
so it gets unlocked eventually, but if the following op in the compound
needs to lock it again, we can deadlock.

A fuzzer ran into this; normal clients don't send a secinfo followed by
a readdir in the same compound.
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 303e186b
...@@ -877,6 +877,7 @@ nfsd4_secinfo(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, ...@@ -877,6 +877,7 @@ nfsd4_secinfo(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
&exp, &dentry); &exp, &dentry);
if (err) if (err)
return err; return err;
fh_unlock(&cstate->current_fh);
if (dentry->d_inode == NULL) { if (dentry->d_inode == NULL) {
exp_put(exp); exp_put(exp);
err = nfserr_noent; err = nfserr_noent;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment