Commit 66077adb authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Borislav Petkov

EDAC/ti: Fix handling of platform_get_irq() error

platform_get_irq() returns a negative error number on error. In such a
case, comparison to 0 would pass the check therefore check the return
value properly, whether it is negative.

 [ bp: Massage commit message. ]

Fixes: 86a18ee2 ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarTero Kristo <t-kristo@ti.com>
Link: https://lkml.kernel.org/r/20200827070743.26628-2-krzk@kernel.org
parent afce6996
...@@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev) ...@@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev)
/* add EMIF ECC error handler */ /* add EMIF ECC error handler */
error_irq = platform_get_irq(pdev, 0); error_irq = platform_get_irq(pdev, 0);
if (!error_irq) { if (error_irq < 0) {
ret = error_irq;
edac_printk(KERN_ERR, EDAC_MOD_NAME, edac_printk(KERN_ERR, EDAC_MOD_NAME,
"EMIF irq number not defined.\n"); "EMIF irq number not defined.\n");
goto err; goto err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment