Commit 669983b4 authored by Alex Williamson's avatar Alex Williamson Committed by Kamal Mostafa

iommu/vt-d: Ratelimit fault handler

commit c43fce4e upstream.

Fault rates can easily overwhelm the console and make the system
unresponsive.  Ratelimit to allow an opportunity for maintenance.
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Fixes: 0ac2491f ('x86, dmar: move page fault handling code to dmar.c')
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 154772d1
...@@ -1575,10 +1575,17 @@ irqreturn_t dmar_fault(int irq, void *dev_id) ...@@ -1575,10 +1575,17 @@ irqreturn_t dmar_fault(int irq, void *dev_id)
int reg, fault_index; int reg, fault_index;
u32 fault_status; u32 fault_status;
unsigned long flag; unsigned long flag;
bool ratelimited;
static DEFINE_RATELIMIT_STATE(rs,
DEFAULT_RATELIMIT_INTERVAL,
DEFAULT_RATELIMIT_BURST);
/* Disable printing, simply clear the fault when ratelimited */
ratelimited = !__ratelimit(&rs);
raw_spin_lock_irqsave(&iommu->register_lock, flag); raw_spin_lock_irqsave(&iommu->register_lock, flag);
fault_status = readl(iommu->reg + DMAR_FSTS_REG); fault_status = readl(iommu->reg + DMAR_FSTS_REG);
if (fault_status) if (fault_status && !ratelimited)
pr_err("DRHD: handling fault status reg %x\n", fault_status); pr_err("DRHD: handling fault status reg %x\n", fault_status);
/* TBD: ignore advanced fault log currently */ /* TBD: ignore advanced fault log currently */
...@@ -1600,24 +1607,28 @@ irqreturn_t dmar_fault(int irq, void *dev_id) ...@@ -1600,24 +1607,28 @@ irqreturn_t dmar_fault(int irq, void *dev_id)
if (!(data & DMA_FRCD_F)) if (!(data & DMA_FRCD_F))
break; break;
fault_reason = dma_frcd_fault_reason(data); if (!ratelimited) {
type = dma_frcd_type(data); fault_reason = dma_frcd_fault_reason(data);
type = dma_frcd_type(data);
data = readl(iommu->reg + reg + data = readl(iommu->reg + reg +
fault_index * PRIMARY_FAULT_REG_LEN + 8); fault_index * PRIMARY_FAULT_REG_LEN + 8);
source_id = dma_frcd_source_id(data); source_id = dma_frcd_source_id(data);
guest_addr = dmar_readq(iommu->reg + reg +
fault_index * PRIMARY_FAULT_REG_LEN);
guest_addr = dma_frcd_page_addr(guest_addr);
}
guest_addr = dmar_readq(iommu->reg + reg +
fault_index * PRIMARY_FAULT_REG_LEN);
guest_addr = dma_frcd_page_addr(guest_addr);
/* clear the fault */ /* clear the fault */
writel(DMA_FRCD_F, iommu->reg + reg + writel(DMA_FRCD_F, iommu->reg + reg +
fault_index * PRIMARY_FAULT_REG_LEN + 12); fault_index * PRIMARY_FAULT_REG_LEN + 12);
raw_spin_unlock_irqrestore(&iommu->register_lock, flag); raw_spin_unlock_irqrestore(&iommu->register_lock, flag);
dmar_fault_do_one(iommu, type, fault_reason, if (!ratelimited)
source_id, guest_addr); dmar_fault_do_one(iommu, type, fault_reason,
source_id, guest_addr);
fault_index++; fault_index++;
if (fault_index >= cap_num_fault_regs(iommu->cap)) if (fault_index >= cap_num_fault_regs(iommu->cap))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment