Commit 6716f397 authored by Anton Protopopov's avatar Anton Protopopov Committed by Kamal Mostafa

rtnl: RTM_GETNETCONF: fix wrong return value

commit a97eb33f upstream.

An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.
Signed-off-by: default avatarAnton Protopopov <a.s.protopopov@gmail.com>
Acked-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent c9603f9f
......@@ -1785,7 +1785,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb,
if (err < 0)
goto errout;
err = EINVAL;
err = -EINVAL;
if (!tb[NETCONFA_IFINDEX])
goto errout;
......
......@@ -531,7 +531,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb,
if (err < 0)
goto errout;
err = EINVAL;
err = -EINVAL;
if (!tb[NETCONFA_IFINDEX])
goto errout;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment