Commit 673d62cd authored by Eric Van Hensbergen's avatar Eric Van Hensbergen

9p: apply common request code to trans_fd

Apply the now common p9_req_t structure to the fd transport.
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent ff683452
...@@ -49,11 +49,12 @@ enum p9_trans_status { ...@@ -49,11 +49,12 @@ enum p9_trans_status {
* enum p9_req_status_t - virtio request status * enum p9_req_status_t - virtio request status
* @REQ_STATUS_IDLE: request slot unused * @REQ_STATUS_IDLE: request slot unused
* @REQ_STATUS_ALLOC: request has been allocated but not sent * @REQ_STATUS_ALLOC: request has been allocated but not sent
* @REQ_STATUS_UNSENT: request waiting to be sent
* @REQ_STATUS_SENT: request sent to server * @REQ_STATUS_SENT: request sent to server
* @REQ_STATUS_FLSH: a flush has been sent for this request * @REQ_STATUS_FLSH: a flush has been sent for this request
* @REQ_STATUS_RCVD: response received from server * @REQ_STATUS_RCVD: response received from server
* @REQ_STATUS_FLSHD: request has been flushed * @REQ_STATUS_FLSHD: request has been flushed
* @REQ_STATUS_ERR: request encountered an error on the client side * @REQ_STATUS_ERROR: request encountered an error on the client side
* *
* The @REQ_STATUS_IDLE state is used to mark a request slot as unused * The @REQ_STATUS_IDLE state is used to mark a request slot as unused
* but use is actually tracked by the idpool structure which handles tag * but use is actually tracked by the idpool structure which handles tag
...@@ -64,6 +65,7 @@ enum p9_trans_status { ...@@ -64,6 +65,7 @@ enum p9_trans_status {
enum p9_req_status_t { enum p9_req_status_t {
REQ_STATUS_IDLE, REQ_STATUS_IDLE,
REQ_STATUS_ALLOC, REQ_STATUS_ALLOC,
REQ_STATUS_UNSENT,
REQ_STATUS_SENT, REQ_STATUS_SENT,
REQ_STATUS_FLSH, REQ_STATUS_FLSH,
REQ_STATUS_RCVD, REQ_STATUS_RCVD,
...@@ -79,6 +81,8 @@ enum p9_req_status_t { ...@@ -79,6 +81,8 @@ enum p9_req_status_t {
* @tc: the request fcall structure * @tc: the request fcall structure
* @rc: the response fcall structure * @rc: the response fcall structure
* @aux: transport specific data (provided for trans_fd migration) * @aux: transport specific data (provided for trans_fd migration)
* @tag: tag on request (BUG: redundant)
* @req_list: link for higher level objects to chain requests
* *
* Transport use an array to track outstanding requests * Transport use an array to track outstanding requests
* instead of a list. While this may incurr overhead during initial * instead of a list. While this may incurr overhead during initial
...@@ -99,6 +103,9 @@ struct p9_req_t { ...@@ -99,6 +103,9 @@ struct p9_req_t {
struct p9_fcall *rc; struct p9_fcall *rc;
u16 flush_tag; u16 flush_tag;
void *aux; void *aux;
int tag;
struct list_head req_list;
}; };
/** /**
...@@ -207,5 +214,6 @@ struct p9_stat *p9_client_dirread(struct p9_fid *fid, u64 offset); ...@@ -207,5 +214,6 @@ struct p9_stat *p9_client_dirread(struct p9_fid *fid, u64 offset);
struct p9_req_t *p9_tag_alloc(struct p9_client *, u16); struct p9_req_t *p9_tag_alloc(struct p9_client *, u16);
struct p9_req_t *p9_tag_lookup(struct p9_client *, u16); struct p9_req_t *p9_tag_lookup(struct p9_client *, u16);
void p9_free_req(struct p9_client *, struct p9_req_t *);
#endif /* NET_9P_CLIENT_H */ #endif /* NET_9P_CLIENT_H */
...@@ -268,6 +268,27 @@ static void p9_tag_cleanup(struct p9_client *c) ...@@ -268,6 +268,27 @@ static void p9_tag_cleanup(struct p9_client *c)
c->max_tag = 0; c->max_tag = 0;
} }
/**
* p9_free_req - free a request and clean-up as necessary
* c: client state
* r: request to release
*
*/
void p9_free_req(struct p9_client *c, struct p9_req_t *r)
{
r->flush_tag = P9_NOTAG;
r->status = REQ_STATUS_IDLE;
if (r->tc->tag != P9_NOTAG && p9_idpool_check(r->tc->tag, c->tagpool))
p9_idpool_put(r->tc->tag, c->tagpool);
/* if this was a flush request we have to free response fcall */
if (r->tc->id == P9_TFLUSH) {
kfree(r->tc);
kfree(r->rc);
}
}
static struct p9_fid *p9_fid_create(struct p9_client *clnt) static struct p9_fid *p9_fid_create(struct p9_client *clnt)
{ {
int err; int err;
......
This diff is collapsed.
...@@ -247,10 +247,7 @@ p9_virtio_rpc(struct p9_client *c, struct p9_fcall *tc, struct p9_fcall **rc) ...@@ -247,10 +247,7 @@ p9_virtio_rpc(struct p9_client *c, struct p9_fcall *tc, struct p9_fcall **rc)
} }
#endif #endif
if (n != P9_NOTAG && p9_idpool_check(n, c->tagpool)) p9_free_req(c, req);
p9_idpool_put(n, c->tagpool);
req->status = REQ_STATUS_IDLE;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment