Commit 689bf406 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Staging: hv: warn the world of a bug in the release function

All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all.  Stick a big fat
WARN_ON(1); in there to get people's attention.


Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f4266e34
......@@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device
static void vmbus_bus_release(struct device *device)
{
DPRINT_ENTER(VMBUS_DRV);
/* FIXME */
/* Empty release functions are a bug, or a major sign
* of a problem design, this MUST BE FIXED! */
dev_err(device, "%s needs to be fixed!\n", __func__);
WARN_ON(1);
DPRINT_EXIT(VMBUS_DRV);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment