Commit 68e9c254 authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Sasha Levin

kvm: fix page struct leak in handle_vmon

[ Upstream commit 06ce521a ]

handle_vmon gets a reference on VMXON region page,
but does not release it. Release the reference.

Found by syzkaller; based on a patch by Dmitry.
Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent f800bced
...@@ -6527,14 +6527,20 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason, ...@@ -6527,14 +6527,20 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
} }
page = nested_get_page(vcpu, vmptr); page = nested_get_page(vcpu, vmptr);
if (page == NULL || if (page == NULL) {
*(u32 *)kmap(page) != VMCS12_REVISION) {
nested_vmx_failInvalid(vcpu); nested_vmx_failInvalid(vcpu);
skip_emulated_instruction(vcpu);
return 1;
}
if (*(u32 *)kmap(page) != VMCS12_REVISION) {
kunmap(page); kunmap(page);
nested_release_page_clean(page);
nested_vmx_failInvalid(vcpu);
skip_emulated_instruction(vcpu); skip_emulated_instruction(vcpu);
return 1; return 1;
} }
kunmap(page); kunmap(page);
nested_release_page_clean(page);
vmx->nested.vmxon_ptr = vmptr; vmx->nested.vmxon_ptr = vmptr;
break; break;
case EXIT_REASON_VMCLEAR: case EXIT_REASON_VMCLEAR:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment