Commit 69166d25 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: es2: Send cport-id in wValue field to usb_control_msg()

wIndex field has a special meaning, as that can be used by the core to
index into the possible USB interfaces. And that specifically broke with
gbsim, as it has a single USB interface.

Other similar requests (REQUEST_LATENCY_TAG_{EN|DIS}) are already using
wValue field for passing cport-id.

Fix cport_reset() by sending the cport-id in wValue field instead of
wIndex.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Tested-by: default avatarFabien Parent <fparent@baylibre.com>
Reviewed-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent f6c6c138
...@@ -440,7 +440,7 @@ static int cport_reset(struct gb_host_device *hd, u16 cport_id) ...@@ -440,7 +440,7 @@ static int cport_reset(struct gb_host_device *hd, u16 cport_id)
retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
REQUEST_RESET_CPORT, REQUEST_RESET_CPORT,
USB_DIR_OUT | USB_TYPE_VENDOR | USB_DIR_OUT | USB_TYPE_VENDOR |
USB_RECIP_INTERFACE, 0, cport_id, USB_RECIP_INTERFACE, cport_id, 0,
NULL, 0, ES2_TIMEOUT); NULL, 0, ES2_TIMEOUT);
if (retval < 0) { if (retval < 0) {
dev_err(&udev->dev, "failed to reset cport %hu: %d\n", cport_id, dev_err(&udev->dev, "failed to reset cport %hu: %d\n", cport_id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment