Commit 6acb47d1 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

phy: ocelot-serdes: fix out-of-bounds read

Currently, there is an out-of-bounds read on array ctrl->phys,
once variable i reaches the maximum array size of SERDES_MAX
in the for loop.

Fix this by changing the condition in the for loop from
i <= SERDES_MAX to i < SERDES_MAX.

Addresses-Coverity-ID: 1473966 ("Out-of-bounds read")
Addresses-Coverity-ID: 1473959 ("Out-of-bounds read")
Fixes: 51f6b410 ("phy: add driver for Microsemi Ocelot SerDes muxing")
Reviewed-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 81fa7a69
...@@ -206,7 +206,7 @@ static struct phy *serdes_simple_xlate(struct device *dev, ...@@ -206,7 +206,7 @@ static struct phy *serdes_simple_xlate(struct device *dev,
port = args->args[0]; port = args->args[0];
idx = args->args[1]; idx = args->args[1];
for (i = 0; i <= SERDES_MAX; i++) { for (i = 0; i < SERDES_MAX; i++) {
struct serdes_macro *macro = phy_get_drvdata(ctrl->phys[i]); struct serdes_macro *macro = phy_get_drvdata(ctrl->phys[i]);
if (idx != macro->idx) if (idx != macro->idx)
...@@ -260,7 +260,7 @@ static int serdes_probe(struct platform_device *pdev) ...@@ -260,7 +260,7 @@ static int serdes_probe(struct platform_device *pdev)
if (IS_ERR(ctrl->regs)) if (IS_ERR(ctrl->regs))
return PTR_ERR(ctrl->regs); return PTR_ERR(ctrl->regs);
for (i = 0; i <= SERDES_MAX; i++) { for (i = 0; i < SERDES_MAX; i++) {
ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]); ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment