Commit 6c356eda authored by Felix Fietkau's avatar Felix Fietkau Committed by James Hogan

MIPS: Lantiq: Fix cascaded IRQ setup

With the IRQ stack changes integrated, the XRX200 devices started
emitting a constant stream of kernel messages like this:

[  565.415310] Spurious IRQ: CAUSE=0x1100c300

This is caused by IP0 getting handled by plat_irq_dispatch() rather than
its vectored interrupt handler, which is fixed by commit de856416e714
("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch").

Fix plat_irq_dispatch() to handle non-vectored IPI interrupts correctly
by setting up IP2-6 as proper chained IRQ handlers and calling do_IRQ
for all MIPS CPU interrupts.
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
Acked-by: default avatarJohn Crispin <john@phrozen.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/15077/
[james.hogan@imgtec.com: tweaked commit message]
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
parent 4fb69afa
...@@ -269,6 +269,11 @@ static void ltq_hw5_irqdispatch(void) ...@@ -269,6 +269,11 @@ static void ltq_hw5_irqdispatch(void)
DEFINE_HWx_IRQDISPATCH(5) DEFINE_HWx_IRQDISPATCH(5)
#endif #endif
static void ltq_hw_irq_handler(struct irq_desc *desc)
{
ltq_hw_irqdispatch(irq_desc_get_irq(desc) - 2);
}
#ifdef CONFIG_MIPS_MT_SMP #ifdef CONFIG_MIPS_MT_SMP
void __init arch_init_ipiirq(int irq, struct irqaction *action) void __init arch_init_ipiirq(int irq, struct irqaction *action)
{ {
...@@ -313,23 +318,19 @@ static struct irqaction irq_call = { ...@@ -313,23 +318,19 @@ static struct irqaction irq_call = {
asmlinkage void plat_irq_dispatch(void) asmlinkage void plat_irq_dispatch(void)
{ {
unsigned int pending = read_c0_status() & read_c0_cause() & ST0_IM; unsigned int pending = read_c0_status() & read_c0_cause() & ST0_IM;
unsigned int i; int irq;
if ((MIPS_CPU_TIMER_IRQ == 7) && (pending & CAUSEF_IP7)) { if (!pending) {
do_IRQ(MIPS_CPU_TIMER_IRQ); spurious_interrupt();
goto out; return;
} else {
for (i = 0; i < MAX_IM; i++) {
if (pending & (CAUSEF_IP2 << i)) {
ltq_hw_irqdispatch(i);
goto out;
}
}
} }
pr_alert("Spurious IRQ: CAUSE=0x%08x\n", read_c0_status());
out: pending >>= CAUSEB_IP;
return; while (pending) {
irq = fls(pending) - 1;
do_IRQ(MIPS_CPU_IRQ_BASE + irq);
pending &= ~BIT(irq);
}
} }
static int icu_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) static int icu_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
...@@ -354,11 +355,6 @@ static const struct irq_domain_ops irq_domain_ops = { ...@@ -354,11 +355,6 @@ static const struct irq_domain_ops irq_domain_ops = {
.map = icu_map, .map = icu_map,
}; };
static struct irqaction cascade = {
.handler = no_action,
.name = "cascade",
};
int __init icu_of_init(struct device_node *node, struct device_node *parent) int __init icu_of_init(struct device_node *node, struct device_node *parent)
{ {
struct device_node *eiu_node; struct device_node *eiu_node;
...@@ -390,7 +386,7 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent) ...@@ -390,7 +386,7 @@ int __init icu_of_init(struct device_node *node, struct device_node *parent)
mips_cpu_irq_init(); mips_cpu_irq_init();
for (i = 0; i < MAX_IM; i++) for (i = 0; i < MAX_IM; i++)
setup_irq(i + 2, &cascade); irq_set_chained_handler(i + 2, ltq_hw_irq_handler);
if (cpu_has_vint) { if (cpu_has_vint) {
pr_info("Setting up vectored interrupts\n"); pr_info("Setting up vectored interrupts\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment