[PATCH] USB: Nag message for usb_kill_urb

This patch is only for nuisance value.  It puts a nag message in the
system log every time usb_unlink_urb() is called for synchronous
unlinking.  My hope is this will speed the process of converting drivers
to use usb_kill_urb().

Don't apply this if it generates too much noise, but otherwise go ahead.
A little prodding never hurt anyone.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

drivers/usb/core/urb.c

@@ -451,6 +451,9 @@ int usb_unlink_urb(struct urb *urb)
 	if (!urb)
 		return -EINVAL;
 	if (!(urb->transfer_flags & URB_ASYNC_UNLINK)) {
+		printk(KERN_NOTICE "usb_unlink_urb() is deprecated for "
+			"synchronous unlinks.  Use usb_kill_urb()\n");
+		WARN_ON(1);
 		usb_kill_urb(urb);
 		return 0;
 	}