Commit 6e6104fe authored by Luca Barbieri's avatar Luca Barbieri Committed by H. Peter Anvin

x86-32: Fix atomic64_add_unless return value convention

atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The implementation did the opposite thing.
Reported-by: default avatarH. Peter Anvin <hpa@zytor.com>
Signed-off-by: default avatarLuca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-3-git-send-email-luca@luca-barbieri.com>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 9efbcd59
...@@ -133,13 +133,13 @@ BEGIN add_unless %ecx ...@@ -133,13 +133,13 @@ BEGIN add_unless %ecx
1: 1:
movl %eax, ($v) movl %eax, ($v)
movl %edx, 4($v) movl %edx, 4($v)
xorl %eax, %eax movl $1, %eax
2: 2:
RETURN RETURN
3: 3:
cmpl %edx, %edi cmpl %edx, %edi
jne 1b jne 1b
movl $1, %eax xorl %eax, %eax
jmp 2b jmp 2b
END_ END_
......
...@@ -180,7 +180,7 @@ ENTRY(atomic64_add_unless_cx8) ...@@ -180,7 +180,7 @@ ENTRY(atomic64_add_unless_cx8)
cmpxchg8b (%ebp) cmpxchg8b (%ebp)
jne 1b jne 1b
xorl %eax, %eax movl $1, %eax
3: 3:
addl $8, %esp addl $8, %esp
CFI_ADJUST_CFA_OFFSET -8 CFI_ADJUST_CFA_OFFSET -8
...@@ -190,7 +190,7 @@ ENTRY(atomic64_add_unless_cx8) ...@@ -190,7 +190,7 @@ ENTRY(atomic64_add_unless_cx8)
4: 4:
cmpl %edx, 4(%esp) cmpl %edx, 4(%esp)
jne 2b jne 2b
movl $1, %eax xorl %eax, %eax
jmp 3b jmp 3b
CFI_ENDPROC CFI_ENDPROC
ENDPROC(atomic64_add_unless_cx8) ENDPROC(atomic64_add_unless_cx8)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment