Commit 71b540ad authored by Gavin Shan's avatar Gavin Shan Committed by Benjamin Herrenschmidt

powerpc/powernv: Don't escalate non-existing frozen PE

Commit cb5b242c ("powerpc/eeh: Escalate error on non-existing PE")
escalates the frozen state on non-existing PE to fenced PHB. It
was to improve kdump reliability. After that, commit 361f2a2a
("powrpc/powernv: Reset PHB in kdump kernel") was introduced to
issue complete reset on all PHBs to increase the reliability of
kdump kernel.

Commit cb5b242c becomes unuseful and it would be reverted.
Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 1ad7a72c
...@@ -794,23 +794,17 @@ static int ioda_eeh_next_error(struct eeh_pe **pe) ...@@ -794,23 +794,17 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
break; break;
case OPAL_EEH_PE_ERROR: case OPAL_EEH_PE_ERROR:
/* /*
* If we can't find the corresponding PE, the * If we can't find the corresponding PE, we
* PEEV / PEST would be messy. So we force an * just try to unfreeze.
* fenced PHB so that it can be recovered.
*
* If the PE has been marked as isolated, that
* should have been removed permanently or in
* progress with recovery. We needn't report
* it again.
*/ */
if (ioda_eeh_get_pe(hose, if (ioda_eeh_get_pe(hose,
be64_to_cpu(frozen_pe_no), pe)) { be64_to_cpu(frozen_pe_no), pe)) {
*pe = phb_pe; /* Try best to clear it */
pr_err("EEH: Escalated fenced PHB#%x " pr_info("EEH: Clear non-existing PHB#%x-PE#%llx\n",
"detected for PE#%llx\n", hose->global_number, frozen_pe_no);
hose->global_number, opal_pci_eeh_freeze_clear(phb->opal_id, frozen_pe_no,
be64_to_cpu(frozen_pe_no)); OPAL_EEH_ACTION_CLEAR_FREEZE_ALL);
ret = EEH_NEXT_ERR_FENCED_PHB; ret = EEH_NEXT_ERR_NONE;
} else if ((*pe)->state & EEH_PE_ISOLATED) { } else if ((*pe)->state & EEH_PE_ISOLATED) {
ret = EEH_NEXT_ERR_NONE; ret = EEH_NEXT_ERR_NONE;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment