Commit 71c33911 authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Ingo Molnar

debug: add the end-of-trace marker and the module list to

Unlike oopses, WARN_ON() currently does't print the loaded modules list.
This makes it harder to take action on certain bug reports. For example,
recently there were a set of WARN_ON()s reported in the mac80211 stack,
which were just signalling a driver bug. It takes then anther round trip
to the bug reporter (if he responds at all) to find out which driver
is at fault.

Another issue is that, unlike oopses, WARN_ON() doesn't currently printk
the helpful "cut here" line, nor the "end of trace" marker.
Now that WARN_ON() is out of line, the size increase due to this is
minimal and it's worth adding.
Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 79b4cc5e
...@@ -281,6 +281,13 @@ static int init_oops_id(void) ...@@ -281,6 +281,13 @@ static int init_oops_id(void)
} }
late_initcall(init_oops_id); late_initcall(init_oops_id);
static void print_oops_end_marker(void)
{
init_oops_id();
printk(KERN_WARNING "---[ end trace %016llx ]---\n",
(unsigned long long)oops_id);
}
/* /*
* Called when the architecture exits its oops handler, after printing * Called when the architecture exits its oops handler, after printing
* everything. * everything.
...@@ -288,9 +295,7 @@ late_initcall(init_oops_id); ...@@ -288,9 +295,7 @@ late_initcall(init_oops_id);
void oops_exit(void) void oops_exit(void)
{ {
do_oops_enter_exit(); do_oops_enter_exit();
init_oops_id(); print_oops_end_marker();
printk(KERN_WARNING "---[ end trace %016llx ]---\n",
(unsigned long long)oops_id);
} }
#ifdef WANT_WARN_ON_SLOWPATH #ifdef WANT_WARN_ON_SLOWPATH
...@@ -298,11 +303,14 @@ void warn_on_slowpath(const char *file, int line) ...@@ -298,11 +303,14 @@ void warn_on_slowpath(const char *file, int line)
{ {
char function[KSYM_SYMBOL_LEN]; char function[KSYM_SYMBOL_LEN];
unsigned long caller = (unsigned long) __builtin_return_address(0); unsigned long caller = (unsigned long) __builtin_return_address(0);
sprint_symbol(function, caller); sprint_symbol(function, caller);
printk(KERN_WARNING "------------[ cut here ]------------\n");
printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
line, function); line, function);
print_modules();
dump_stack(); dump_stack();
print_oops_end_marker();
} }
EXPORT_SYMBOL(warn_on_slowpath); EXPORT_SYMBOL(warn_on_slowpath);
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment