Commit 73024cf1 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Nathan Scott

[XFS] Fix realtime subvolume expansion, a porting bug b0rked it. Coverity

made me look at this code (bug id #344). We only return with
XFS_ERROR(EINVAL) if mp->m_rtdev_targp is valid and pass it otherwise to
xfs_read_buf() where some function calls later it gets dereferenced by an
assert.

SGI-PV: 954266
SGI-Modid: xfs-linux-melb:xfs-kern:26363a
Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: default avatarNathan Scott <nathans@sgi.com>
parent 97dfd70c
...@@ -1929,7 +1929,7 @@ xfs_growfs_rt( ...@@ -1929,7 +1929,7 @@ xfs_growfs_rt(
/* /*
* Initial error checking. * Initial error checking.
*/ */
if (mp->m_rtdev_targp || mp->m_rbmip == NULL || if (mp->m_rtdev_targp == NULL || mp->m_rbmip == NULL ||
(nrblocks = in->newblocks) <= sbp->sb_rblocks || (nrblocks = in->newblocks) <= sbp->sb_rblocks ||
(sbp->sb_rblocks && (in->extsize != sbp->sb_rextsize))) (sbp->sb_rblocks && (in->extsize != sbp->sb_rextsize)))
return XFS_ERROR(EINVAL); return XFS_ERROR(EINVAL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment