Commit 751ad34f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Dmitry Torokhov

Input: adi - work around module name confict

Making module name conflicts a fatal error breaks sparc64 allmodconfig:

Error log:
error: the following would cause module name conflict:
  drivers/char/adi.ko
  drivers/input/joystick/adi.ko

Renaming one of the modules would solve the problem, but then cause other
problems because neither of them is automatically loaded and changing
the name is likely to break any setup that relies on manually loading
it by name.

As there is probably no sparc64 system with this kind of ancient joystick
attached, work around it by adding a Kconfig dependency that forbids
them from both being modules.  It is still possible to build the joystick
driver if the sparc64 adi driver is built-in.
Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200609100643.1245061-1-arnd@arndb.deSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 8dd06ef3
...@@ -45,6 +45,7 @@ config JOYSTICK_A3D ...@@ -45,6 +45,7 @@ config JOYSTICK_A3D
config JOYSTICK_ADI config JOYSTICK_ADI
tristate "Logitech ADI digital joysticks and gamepads" tristate "Logitech ADI digital joysticks and gamepads"
select GAMEPORT select GAMEPORT
depends on ADI!=m # avoid module name conflict
help help
Say Y here if you have a Logitech controller using the ADI Say Y here if you have a Logitech controller using the ADI
protocol over the PC gameport. protocol over the PC gameport.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment