Commit 753419f5 authored by Vishwanath BS's avatar Vishwanath BS Committed by Jean Delvare

i2c: Fix for suspend/resume issue

In current i2c core driver, call to pm_runtime_set_active from
i2c_device_pm_resume will unconditionally enable i2c module and
increment child count of the parent. Because of this, in CPU Idle
path, i2c does not idle, preventing Core to enter retention. Also i2c
module will not be suspended upon system suspend as
pm_runtime_set_suspended is not called from i2c_device_pm_suspend.

This issue is fixed by removing pm_runtime_set_active call from resume
path which is not necessary.
This fix has been tested on OMAP4430.
Signed-off-by: default avatarPartha Basak <p-basak2@ti.com>
Signed-off-by: default avatarVishwanath BS <vishwanath.bs@ti.com>
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 59bfee6e
...@@ -216,12 +216,6 @@ static int i2c_device_pm_resume(struct device *dev) ...@@ -216,12 +216,6 @@ static int i2c_device_pm_resume(struct device *dev)
else else
ret = i2c_legacy_resume(dev); ret = i2c_legacy_resume(dev);
if (!ret) {
pm_runtime_disable(dev);
pm_runtime_set_active(dev);
pm_runtime_enable(dev);
}
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment