Commit 758914fe authored by Jim Wilson's avatar Jim Wilson Committed by Palmer Dabbelt

RISC-V: Don't increment sepc after breakpoint.

Adding 4 to sepc is pointless, and is wrong if we executed a 2-byte
compressed breakpoint.  This plus a corresponding gdb patch allows
compressed breakpoints to work in gdb.  Gdb maintainers have already
agreed that this is the right approach.
Signed-off-by: default avatarJim Wilson <jimw@sifive.com>
Signed-off-by: default avatarPalmer Dabbelt <palmer@sifive.com>
parent a89757da
...@@ -138,7 +138,6 @@ asmlinkage void do_trap_break(struct pt_regs *regs) ...@@ -138,7 +138,6 @@ asmlinkage void do_trap_break(struct pt_regs *regs)
#endif /* CONFIG_GENERIC_BUG */ #endif /* CONFIG_GENERIC_BUG */
force_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)(regs->sepc), current); force_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)(regs->sepc), current);
regs->sepc += 0x4;
} }
#ifdef CONFIG_GENERIC_BUG #ifdef CONFIG_GENERIC_BUG
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment