Commit 75d14ede authored by Jason Wessel's avatar Jason Wessel

kdb: Fix oops in kdb_unregister

Nothing should try to use kdb_commands directly as sometimes it is
null.  Instead, use the for_each_kdbcmd() iterator.

This particular problem dates back to the initial kdb merge (2.6.35),
but at that point nothing was dynamically unregistering commands from
the kdb shell.
Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
parent e3bda3ac
...@@ -2826,7 +2826,7 @@ int kdb_unregister(char *cmd) ...@@ -2826,7 +2826,7 @@ int kdb_unregister(char *cmd)
/* /*
* find the command. * find the command.
*/ */
for (i = 0, kp = kdb_commands; i < kdb_max_commands; i++, kp++) { for_each_kdbcmd(kp, i) {
if (kp->cmd_name && (strcmp(kp->cmd_name, cmd) == 0)) { if (kp->cmd_name && (strcmp(kp->cmd_name, cmd) == 0)) {
kp->cmd_name = NULL; kp->cmd_name = NULL;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment