Commit 76223c54 authored by Xiangliang Yu's avatar Xiangliang Yu Committed by Alex Deucher

drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

There isn't ucode when executing INVOKE command, so current code can't
check the failure of INVOKE command.

Remove the ucode check.
Signed-off-by: default avatarXiangliang Yu <Xiangliang.Yu@amd.com>
Reviewed-by: default avatarFeifei Xu <Feifei.Xu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 898e0d9d
...@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp, ...@@ -140,10 +140,13 @@ psp_cmd_submit_buf(struct psp_context *psp,
while (*((unsigned int *)psp->fence_buf) != index) while (*((unsigned int *)psp->fence_buf) != index)
msleep(1); msleep(1);
/* the status field must be 0 after FW is loaded */ /* the status field must be 0 after psp command completion */
if (ucode && psp->cmd_buf_mem->resp.status) { if (psp->cmd_buf_mem->resp.status) {
DRM_ERROR("failed loading with status (%d) and ucode id (%d)\n", if (ucode)
psp->cmd_buf_mem->resp.status, ucode->ucode_id); DRM_ERROR("failed to load ucode id (%d) ",
ucode->ucode_id);
DRM_ERROR("psp command failed and response status is (%d)\n",
psp->cmd_buf_mem->resp.status);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment