Commit 77795318 authored by Pavel Andrianov's avatar Pavel Andrianov Committed by Greg Kroah-Hartman

speakup: Add spinlock in synth_direct_store

All operations with synth buffer should be protected,
as there are global pointers, which should be modified atomically.

Found by Linux Driver Verification project (linuxtesting.org)
Signed-off-by: default avatarPavel Andrianov <andrianov@ispras.ru>
Acked-by: default avatarVaishali Thakkar <vaishali.thakkar@oracle.com>
Reviewed-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent da25a8ec
...@@ -411,11 +411,13 @@ static ssize_t synth_direct_store(struct kobject *kobj, ...@@ -411,11 +411,13 @@ static ssize_t synth_direct_store(struct kobject *kobj,
int len; int len;
int bytes; int bytes;
const char *ptr = buf; const char *ptr = buf;
unsigned long flags;
if (!synth) if (!synth)
return -EPERM; return -EPERM;
len = strlen(buf); len = strlen(buf);
spin_lock_irqsave(&speakup_info.spinlock, flags);
while (len > 0) { while (len > 0) {
bytes = min_t(size_t, len, 250); bytes = min_t(size_t, len, 250);
strncpy(tmp, ptr, bytes); strncpy(tmp, ptr, bytes);
...@@ -425,6 +427,7 @@ static ssize_t synth_direct_store(struct kobject *kobj, ...@@ -425,6 +427,7 @@ static ssize_t synth_direct_store(struct kobject *kobj,
ptr += bytes; ptr += bytes;
len -= bytes; len -= bytes;
} }
spin_unlock_irqrestore(&speakup_info.spinlock, flags);
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment