Commit 7949d20c authored by Wei Yongjun's avatar Wei Yongjun Committed by John W. Linville

ipw2200: use is_zero_ether_addr() and is_broadcast_ether_addr()

Using is_zero_ether_addr() and is_broadcast_ether_addr() instead of
directly use memcmp() to determine if the ethernet address is all zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 96e716b2
...@@ -9037,18 +9037,11 @@ static int ipw_wx_set_wap(struct net_device *dev, ...@@ -9037,18 +9037,11 @@ static int ipw_wx_set_wap(struct net_device *dev,
{ {
struct ipw_priv *priv = libipw_priv(dev); struct ipw_priv *priv = libipw_priv(dev);
static const unsigned char any[] = {
0xff, 0xff, 0xff, 0xff, 0xff, 0xff
};
static const unsigned char off[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00
};
if (wrqu->ap_addr.sa_family != ARPHRD_ETHER) if (wrqu->ap_addr.sa_family != ARPHRD_ETHER)
return -EINVAL; return -EINVAL;
mutex_lock(&priv->mutex); mutex_lock(&priv->mutex);
if (!memcmp(any, wrqu->ap_addr.sa_data, ETH_ALEN) || if (is_broadcast_ether_addr(wrqu->ap_addr.sa_data) ||
!memcmp(off, wrqu->ap_addr.sa_data, ETH_ALEN)) { is_zero_ether_addr(wrqu->ap_addr.sa_data)) {
/* we disable mandatory BSSID association */ /* we disable mandatory BSSID association */
IPW_DEBUG_WX("Setting AP BSSID to ANY\n"); IPW_DEBUG_WX("Setting AP BSSID to ANY\n");
priv->config &= ~CFG_STATIC_BSSID; priv->config &= ~CFG_STATIC_BSSID;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment