Commit 79a2eda8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

[media] mantis_dvb: fix some error codes in mantis_dvb_init()

We should be returning negative error codes here or it leads to a crash.
This also silences a static checker warning.

	drivers/media/pci/mantis/mantis_cards.c:250 mantis_pci_probe()
	warn: 'mantis->dmxdev.dvbdev->fops' double freed
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent c2987aaf
...@@ -226,11 +226,12 @@ int mantis_dvb_init(struct mantis_pci *mantis) ...@@ -226,11 +226,12 @@ int mantis_dvb_init(struct mantis_pci *mantis)
goto err5; goto err5;
} else { } else {
if (mantis->fe == NULL) { if (mantis->fe == NULL) {
result = -ENOMEM;
dprintk(MANTIS_ERROR, 1, "FE <NULL>"); dprintk(MANTIS_ERROR, 1, "FE <NULL>");
goto err5; goto err5;
} }
result = dvb_register_frontend(&mantis->dvb_adapter, mantis->fe);
if (dvb_register_frontend(&mantis->dvb_adapter, mantis->fe)) { if (result) {
dprintk(MANTIS_ERROR, 1, "ERROR: Frontend registration failed"); dprintk(MANTIS_ERROR, 1, "ERROR: Frontend registration failed");
if (mantis->fe->ops.release) if (mantis->fe->ops.release)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment