Commit 79a35a44 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Linus Torvalds

[PATCH] Ext[23]: apply umask to symlinks with ACLs configured out

Keith Young <stripyd@stripydog.com> has reported that when ACLs are not
compiled in, the default implementation of ext[23]_init_acl applies the
umask to all new files, including symlinks, which is wrong.  In this case
the VFS already takes care of applying the umask when needed, so ext2 and
ext3 need not bother about it.  Remove the superfluous statements.
Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent eed6b962
......@@ -77,7 +77,6 @@ ext2_acl_chmod (struct inode *inode)
static inline int ext2_init_acl (struct inode *inode, struct inode *dir)
{
inode->i_mode &= ~current->fs->umask;
return 0;
}
#endif
......
......@@ -79,7 +79,6 @@ ext3_acl_chmod(struct inode *inode)
static inline int
ext3_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
{
inode->i_mode &= ~current->fs->umask;
return 0;
}
#endif /* CONFIG_EXT3_FS_POSIX_ACL */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment