Commit 7aed9f72 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Theodore Ts'o

net/route: use get_random_int for random counter

Using get_random_int here is faster, more fitting of the use case, and
just as cryptographically secure. It also has the benefit of providing
better randomness at early boot, which is when many of these structures
are assigned.

Also, semantically, it's not really proper to have been assigning an
atomic_t in this way before, even if in practice it works fine.
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent b3d0f789
...@@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net) ...@@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net)
{ {
atomic_set(&net->ipv4.rt_genid, 0); atomic_set(&net->ipv4.rt_genid, 0);
atomic_set(&net->fnhe_genid, 0); atomic_set(&net->fnhe_genid, 0);
get_random_bytes(&net->ipv4.dev_addr_genid, atomic_set(&net->ipv4.dev_addr_genid, get_random_int());
sizeof(net->ipv4.dev_addr_genid));
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment