Commit 7afcaec4 authored by Veaceslav Falico's avatar Veaceslav Falico Committed by David S. Miller

bonding: use kobject_put instead of _del after kobject_add

Otherwise the name of the kobject isn't getting freed and other stuff from
kobject_cleanup() isn't getting called. kobject_put() will call
kobject_del() on its own in kobject_cleanup().

CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: default avatarVeaceslav Falico <vfalico@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c36c9d50
...@@ -125,7 +125,7 @@ int bond_sysfs_slave_add(struct slave *slave) ...@@ -125,7 +125,7 @@ int bond_sysfs_slave_add(struct slave *slave)
for (a = slave_attrs; *a; ++a) { for (a = slave_attrs; *a; ++a) {
err = sysfs_create_file(&slave->kobj, &((*a)->attr)); err = sysfs_create_file(&slave->kobj, &((*a)->attr));
if (err) { if (err) {
kobject_del(&slave->kobj); kobject_put(&slave->kobj);
return err; return err;
} }
} }
...@@ -140,5 +140,5 @@ void bond_sysfs_slave_del(struct slave *slave) ...@@ -140,5 +140,5 @@ void bond_sysfs_slave_del(struct slave *slave)
for (a = slave_attrs; *a; ++a) for (a = slave_attrs; *a; ++a)
sysfs_remove_file(&slave->kobj, &((*a)->attr)); sysfs_remove_file(&slave->kobj, &((*a)->attr));
kobject_del(&slave->kobj); kobject_put(&slave->kobj);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment