Commit 7b2ac386 authored by Anton Altaparmakov's avatar Anton Altaparmakov

NTFS: Cleanups, mostly whitespace. Found during resync with 2.4 backport.

parent 456f17cd
...@@ -385,7 +385,7 @@ int ntfs_readpage(struct file *file, struct page *page) ...@@ -385,7 +385,7 @@ int ntfs_readpage(struct file *file, struct page *page)
else else
base_ni = ni->_INE(base_ntfs_ino); base_ni = ni->_INE(base_ntfs_ino);
/* Map, pin and lock the mft record. */ /* Map, pin, and lock the mft record. */
mrec = map_mft_record(base_ni); mrec = map_mft_record(base_ni);
if (unlikely(IS_ERR(mrec))) { if (unlikely(IS_ERR(mrec))) {
err = PTR_ERR(mrec); err = PTR_ERR(mrec);
......
...@@ -1676,7 +1676,7 @@ void reinit_attr_search_ctx(attr_search_context *ctx) ...@@ -1676,7 +1676,7 @@ void reinit_attr_search_ctx(attr_search_context *ctx)
return; return;
} /* Attribute list. */ } /* Attribute list. */
if (ctx->ntfs_ino != ctx->base_ntfs_ino) if (ctx->ntfs_ino != ctx->base_ntfs_ino)
unmap_mft_record(ctx->ntfs_ino); unmap_extent_mft_record(ctx->ntfs_ino);
init_attr_search_ctx(ctx, ctx->base_ntfs_ino, ctx->base_mrec); init_attr_search_ctx(ctx, ctx->base_ntfs_ino, ctx->base_mrec);
return; return;
} }
...@@ -1709,7 +1709,7 @@ attr_search_context *get_attr_search_ctx(ntfs_inode *ni, MFT_RECORD *mrec) ...@@ -1709,7 +1709,7 @@ attr_search_context *get_attr_search_ctx(ntfs_inode *ni, MFT_RECORD *mrec)
void put_attr_search_ctx(attr_search_context *ctx) void put_attr_search_ctx(attr_search_context *ctx)
{ {
if (ctx->base_ntfs_ino && ctx->ntfs_ino != ctx->base_ntfs_ino) if (ctx->base_ntfs_ino && ctx->ntfs_ino != ctx->base_ntfs_ino)
unmap_mft_record(ctx->ntfs_ino); unmap_extent_mft_record(ctx->ntfs_ino);
kmem_cache_free(ntfs_attr_ctx_cache, ctx); kmem_cache_free(ntfs_attr_ctx_cache, ctx);
return; return;
} }
......
...@@ -609,18 +609,18 @@ int ntfs_read_compressed_block(struct page *page) ...@@ -609,18 +609,18 @@ int ntfs_read_compressed_block(struct page *page)
if (buffer_uptodate(tbh)) if (buffer_uptodate(tbh))
continue; continue;
wait_on_buffer(tbh); wait_on_buffer(tbh);
/* /*
* We need an optimization barrier here, otherwise we start * We need an optimization barrier here, otherwise we start
* hitting the below fixup code when accessing a loopback * hitting the below fixup code when accessing a loopback
* mounted ntfs partition. This indicates either there is a * mounted ntfs partition. This indicates either there is a
* race condition in the loop driver or, more likely, gcc * race condition in the loop driver or, more likely, gcc
* overoptimises the code without the barrier and it doesn't * overoptimises the code without the barrier and it doesn't
* do the Right Thing(TM). * do the Right Thing(TM).
*/ */
barrier(); barrier();
if (unlikely(!buffer_uptodate(tbh))) { if (unlikely(!buffer_uptodate(tbh))) {
ntfs_warning(vol->sb, "Buffer is unlocked but not " ntfs_warning(vol->sb, "Buffer is unlocked but not "
"uptodate! Unplugging the disk queue " "uptodate! Unplugging the disk queue "
"and rescheduling."); "and rescheduling.");
get_bh(tbh); get_bh(tbh);
blk_run_queues(); blk_run_queues();
......
...@@ -1048,9 +1048,7 @@ static inline int ntfs_filldir(ntfs_volume *vol, loff_t *fpos, ...@@ -1048,9 +1048,7 @@ static inline int ntfs_filldir(ntfs_volume *vol, loff_t *fpos,
/* /*
* VFS calls readdir without BKL but with i_sem held. This protects the VFS * VFS calls readdir without BKL but with i_sem held. This protects the VFS
* parts (e.g. ->f_pos and ->i_size, and it also protects against directory * parts (e.g. ->f_pos and ->i_size, and it also protects against directory
* modifications). Together with the rw semaphore taken by the call to * modifications).
* map_mft_record(), the directory is truly locked down so we have a race free
* ntfs_readdir() without the BKL. (-:
* *
* We use the same basic approach as the old NTFS driver, i.e. we parse the * We use the same basic approach as the old NTFS driver, i.e. we parse the
* index root entries and then the index allocation entries that are marked * index root entries and then the index allocation entries that are marked
...@@ -1181,7 +1179,7 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir) ...@@ -1181,7 +1179,7 @@ static int ntfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
*/ */
put_attr_search_ctx(ctx); put_attr_search_ctx(ctx);
unmap_mft_record(ndir); unmap_mft_record(ndir);
m = NULL; m = NULL;
ctx = NULL; ctx = NULL;
/* If there is no index allocation attribute we are finished. */ /* If there is no index allocation attribute we are finished. */
if (!NInoIndexAllocPresent(ndir)) if (!NInoIndexAllocPresent(ndir))
......
...@@ -844,7 +844,7 @@ static int ntfs_read_locked_inode(struct inode *vi) ...@@ -844,7 +844,7 @@ static int ntfs_read_locked_inode(struct inode *vi)
ctx->attr->_ANR(allocated_size)); ctx->attr->_ANR(allocated_size));
/* /*
* We are done with the mft record, so we release it. Otherwise * We are done with the mft record, so we release it. Otherwise
* * we would deadlock in ntfs_attr_iget().
*/ */
put_attr_search_ctx(ctx); put_attr_search_ctx(ctx);
unmap_mft_record(ni); unmap_mft_record(ni);
......
...@@ -176,8 +176,8 @@ static inline MFT_RECORD *map_mft_record_page(ntfs_inode *ni) ...@@ -176,8 +176,8 @@ static inline MFT_RECORD *map_mft_record_page(ntfs_inode *ni)
* First, take the mrec_lock semaphore. We might now be sleeping, while waiting * First, take the mrec_lock semaphore. We might now be sleeping, while waiting
* for the semaphore if it was already locked by someone else. * for the semaphore if it was already locked by someone else.
* *
* The page of the record is first mapped using map_mft_record_page() before * The page of the record is mapped using map_mft_record_page() before being
* being returned to the caller. * returned to the caller.
* *
* This in turn uses ntfs_map_page() to get the page containing the wanted mft * This in turn uses ntfs_map_page() to get the page containing the wanted mft
* record (it in turn calls read_cache_page() which reads it in from disk if * record (it in turn calls read_cache_page() which reads it in from disk if
......
...@@ -139,8 +139,8 @@ static struct dentry *ntfs_lookup(struct inode *dir_ino, struct dentry *dent) ...@@ -139,8 +139,8 @@ static struct dentry *ntfs_lookup(struct inode *dir_ino, struct dentry *dent)
dent_inode = ERR_PTR(-EIO); dent_inode = ERR_PTR(-EIO);
} else } else
ntfs_error(vol->sb, "ntfs_iget(0x%lx) failed with " ntfs_error(vol->sb, "ntfs_iget(0x%lx) failed with "
"error code %li.", dent_ino, "error code %li.", dent_ino,
PTR_ERR(dent_inode)); PTR_ERR(dent_inode));
if (name) if (name)
kfree(name); kfree(name);
/* Return the error code. */ /* Return the error code. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment