Commit 7c1fca33 authored by Stefan Richter's avatar Stefan Richter

firewire: fw-sbp2: fix reference counting

The reference count of the unit dropped too low in an error path in
sbp2_probe.  Fixed by moving the _get further up.
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: default avatarJarod Wilson <jwilson@redhat.com>
parent bd7dee63
...@@ -1119,6 +1119,7 @@ static int sbp2_probe(struct device *dev) ...@@ -1119,6 +1119,7 @@ static int sbp2_probe(struct device *dev)
goto fail_shost_put; goto fail_shost_put;
fw_device_get(device); fw_device_get(device);
get_device(&unit->device);
/* Initialize to values that won't match anything in our table. */ /* Initialize to values that won't match anything in our table. */
firmware_revision = 0xff000000; firmware_revision = 0xff000000;
...@@ -1134,8 +1135,6 @@ static int sbp2_probe(struct device *dev) ...@@ -1134,8 +1135,6 @@ static int sbp2_probe(struct device *dev)
sbp2_init_workarounds(tgt, model, firmware_revision); sbp2_init_workarounds(tgt, model, firmware_revision);
get_device(&unit->device);
/* Do the login in a workqueue so we can easily reschedule retries. */ /* Do the login in a workqueue so we can easily reschedule retries. */
list_for_each_entry(lu, &tgt->lu_list, link) list_for_each_entry(lu, &tgt->lu_list, link)
sbp2_queue_work(lu, 0); sbp2_queue_work(lu, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment