Commit 7dfad418 authored by Hugh Dickins's avatar Hugh Dickins Committed by Linus Torvalds

[PATCH] swap: scan_swap_map restyled

Rewrite scan_swap_map to allocate in just the same way as before (taking the
next free entry SWAPFILE_CLUSTER-1 times, then restarting at the lowest wholly
empty cluster, falling back to lowest entry if none), but with a view towards
dropping the lock in the next patch.
Signed-off-by: default avatarHugh Dickins <hugh@veritas.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent fb4f88dc
...@@ -86,64 +86,67 @@ void swap_unplug_io_fn(struct backing_dev_info *unused_bdi, struct page *page) ...@@ -86,64 +86,67 @@ void swap_unplug_io_fn(struct backing_dev_info *unused_bdi, struct page *page)
static inline unsigned long scan_swap_map(struct swap_info_struct *si) static inline unsigned long scan_swap_map(struct swap_info_struct *si)
{ {
unsigned long offset; unsigned long offset, last_in_cluster;
/* /*
* We try to cluster swap pages by allocating them * We try to cluster swap pages by allocating them sequentially
* sequentially in swap. Once we've allocated * in swap. Once we've allocated SWAPFILE_CLUSTER pages this
* SWAPFILE_CLUSTER pages this way, however, we resort to * way, however, we resort to first-free allocation, starting
* first-free allocation, starting a new cluster. This * a new cluster. This prevents us from scattering swap pages
* prevents us from scattering swap pages all over the entire * all over the entire swap partition, so that we reduce
* swap partition, so that we reduce overall disk seek times * overall disk seek times between swap pages. -- sct
* between swap pages. -- sct */ * But we do now try to find an empty cluster. -Andrea
if (si->cluster_nr) { */
while (si->cluster_next <= si->highest_bit) {
offset = si->cluster_next++; if (unlikely(!si->cluster_nr)) {
si->cluster_nr = SWAPFILE_CLUSTER - 1;
if (si->pages - si->inuse_pages < SWAPFILE_CLUSTER)
goto lowest;
offset = si->lowest_bit;
last_in_cluster = offset + SWAPFILE_CLUSTER - 1;
/* Locate the first empty (unaligned) cluster */
for (; last_in_cluster <= si->highest_bit; offset++) {
if (si->swap_map[offset]) if (si->swap_map[offset])
continue; last_in_cluster = offset + SWAPFILE_CLUSTER;
si->cluster_nr--; else if (offset == last_in_cluster) {
goto got_page; si->cluster_next = offset-SWAPFILE_CLUSTER-1;
} goto cluster;
}
si->cluster_nr = SWAPFILE_CLUSTER;
/* try to find an empty (even not aligned) cluster. */
offset = si->lowest_bit;
check_next_cluster:
if (offset+SWAPFILE_CLUSTER-1 <= si->highest_bit)
{
unsigned long nr;
for (nr = offset; nr < offset+SWAPFILE_CLUSTER; nr++)
if (si->swap_map[nr])
{
offset = nr+1;
goto check_next_cluster;
} }
/* We found a completly empty cluster, so start }
* using it. goto lowest;
*/
goto got_page;
} }
/* No luck, so now go finegrined as usual. -Andrea */
for (offset = si->lowest_bit; offset <= si->highest_bit ; offset++) { si->cluster_nr--;
if (si->swap_map[offset]) cluster:
continue; offset = si->cluster_next;
si->lowest_bit = offset+1; if (offset > si->highest_bit)
got_page: lowest: offset = si->lowest_bit;
if (offset == si->lowest_bit) if (!si->highest_bit)
goto no_page;
if (!si->swap_map[offset]) {
got_page: if (offset == si->lowest_bit)
si->lowest_bit++; si->lowest_bit++;
if (offset == si->highest_bit) if (offset == si->highest_bit)
si->highest_bit--; si->highest_bit--;
if (si->lowest_bit > si->highest_bit) { si->inuse_pages++;
if (si->inuse_pages == si->pages) {
si->lowest_bit = si->max; si->lowest_bit = si->max;
si->highest_bit = 0; si->highest_bit = 0;
} }
si->swap_map[offset] = 1; si->swap_map[offset] = 1;
si->inuse_pages++; si->cluster_next = offset + 1;
si->cluster_next = offset+1;
return offset; return offset;
} }
si->lowest_bit = si->max;
si->highest_bit = 0; while (++offset <= si->highest_bit) {
if (!si->swap_map[offset])
goto got_page;
}
goto lowest;
no_page:
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment