Commit 7e75678d authored by Furquan Shaikh's avatar Furquan Shaikh Committed by Kees Cook

pstore/ram: Use memcpy_toio instead of memcpy

persistent_ram_update uses vmap / iomap based on whether the buffer is in
memory region or reserved region. However, both map it as non-cacheable
memory. For armv8 specifically, non-cacheable mapping requests use a
memory type that has to be accessed aligned to the request size. memcpy()
doesn't guarantee that.
Signed-off-by: default avatarFurquan Shaikh <furquan@google.com>
Signed-off-by: default avatarEnric Balletbo Serra <enric.balletbo@collabora.com>
Reviewed-by: default avatarAaron Durbin <adurbin@chromium.org>
Reviewed-by: default avatarOlof Johansson <olofj@chromium.org>
Tested-by: default avatarFurquan Shaikh <furquan@chromium.org>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
parent 5bf6d1b9
...@@ -264,7 +264,7 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz, ...@@ -264,7 +264,7 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz,
const void *s, unsigned int start, unsigned int count) const void *s, unsigned int start, unsigned int count)
{ {
struct persistent_ram_buffer *buffer = prz->buffer; struct persistent_ram_buffer *buffer = prz->buffer;
memcpy(buffer->data + start, s, count); memcpy_toio(buffer->data + start, s, count);
persistent_ram_update_ecc(prz, start, count); persistent_ram_update_ecc(prz, start, count);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment