Commit 7f2bad4b authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman

Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls

Fix the bogus WARN_ON() calls.
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 28e0d066
...@@ -200,7 +200,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device) ...@@ -200,7 +200,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device)
static void free_input_device(struct mousevsc_dev *device) static void free_input_device(struct mousevsc_dev *device)
{ {
WARN_ON(atomic_read(&device->ref_count) == 0); WARN_ON(atomic_read(&device->ref_count) != 0);
kfree(device); kfree(device);
} }
...@@ -327,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, ...@@ -327,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
/* Save the hid desc */ /* Save the hid desc */
desc = &device_info->hid_descriptor; desc = &device_info->hid_descriptor;
WARN_ON(desc->bLength > 0); WARN_ON(desc->bLength == 0);
input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL); input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL);
...@@ -447,7 +447,7 @@ static void mousevsc_on_receive(struct hv_device *device, ...@@ -447,7 +447,7 @@ static void mousevsc_on_receive(struct hv_device *device,
break; break;
case SynthHidInitialDeviceInfo: case SynthHidInitialDeviceInfo:
WARN_ON(pipe_msg->size >= sizeof(struct hv_input_dev_info)); WARN_ON(pipe_msg->size < sizeof(struct hv_input_dev_info));
/* /*
* Parse out the device info into device attr, * Parse out the device info into device attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment