Commit 7f9d2b1c authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Greg Kroah-Hartman

staging: comedi: drivers: ni_mio_common: Prefer using macro DIV_ROUND_UP

The macro DIV_ROUND_UP performs the computation
(((n) + (d) - 1) /(d)). It clarifies the divisor calculations.
This was done using the coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e1,e2)
)
Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df6ba4f1
...@@ -2058,7 +2058,7 @@ static int ni_ns_to_timer(const struct comedi_device *dev, unsigned nanosec, ...@@ -2058,7 +2058,7 @@ static int ni_ns_to_timer(const struct comedi_device *dev, unsigned nanosec,
divider = (nanosec) / devpriv->clock_ns; divider = (nanosec) / devpriv->clock_ns;
break; break;
case CMDF_ROUND_UP: case CMDF_ROUND_UP:
divider = (nanosec + devpriv->clock_ns - 1) / devpriv->clock_ns; divider = DIV_ROUND_UP(nanosec, devpriv->clock_ns);
break; break;
} }
return divider - 1; return divider - 1;
...@@ -4241,8 +4241,7 @@ static int ni_m_series_pwm_config(struct comedi_device *dev, ...@@ -4241,8 +4241,7 @@ static int ni_m_series_pwm_config(struct comedi_device *dev,
break; break;
case CMDF_ROUND_UP: case CMDF_ROUND_UP:
up_count = up_count =
(data[2] + devpriv->clock_ns - DIV_ROUND_UP(data[2], devpriv->clock_ns);
1) / devpriv->clock_ns;
break; break;
default: default:
return -EINVAL; return -EINVAL;
...@@ -4257,8 +4256,7 @@ static int ni_m_series_pwm_config(struct comedi_device *dev, ...@@ -4257,8 +4256,7 @@ static int ni_m_series_pwm_config(struct comedi_device *dev,
break; break;
case CMDF_ROUND_UP: case CMDF_ROUND_UP:
down_count = down_count =
(data[4] + devpriv->clock_ns - DIV_ROUND_UP(data[4], devpriv->clock_ns);
1) / devpriv->clock_ns;
break; break;
default: default:
return -EINVAL; return -EINVAL;
...@@ -4303,8 +4301,7 @@ static int ni_6143_pwm_config(struct comedi_device *dev, ...@@ -4303,8 +4301,7 @@ static int ni_6143_pwm_config(struct comedi_device *dev,
break; break;
case CMDF_ROUND_UP: case CMDF_ROUND_UP:
up_count = up_count =
(data[2] + devpriv->clock_ns - DIV_ROUND_UP(data[2], devpriv->clock_ns);
1) / devpriv->clock_ns;
break; break;
default: default:
return -EINVAL; return -EINVAL;
...@@ -4319,8 +4316,7 @@ static int ni_6143_pwm_config(struct comedi_device *dev, ...@@ -4319,8 +4316,7 @@ static int ni_6143_pwm_config(struct comedi_device *dev,
break; break;
case CMDF_ROUND_UP: case CMDF_ROUND_UP:
down_count = down_count =
(data[4] + devpriv->clock_ns - DIV_ROUND_UP(data[4], devpriv->clock_ns);
1) / devpriv->clock_ns;
break; break;
default: default:
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment