Commit 80f51c32 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman

gma500: add more ops

Split the 2d properties, name, and various function vectors out so that we
can get rid of more conditional gloop in favour of a per device structure.
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 71138b7f
...@@ -687,6 +687,11 @@ static int mdfld_power_up(struct drm_device *dev) ...@@ -687,6 +687,11 @@ static int mdfld_power_up(struct drm_device *dev)
} }
const struct psb_ops mdfld_chip_ops = { const struct psb_ops mdfld_chip_ops = {
.name = "Medfield",
.accel_2d = 0,
.crtc_helper = &mdfld_helper_funcs,
.crtc_funcs = &mdfld_intel_crtc_funcs,
.output_init = mdfld_output_init, .output_init = mdfld_output_init,
#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE #ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
......
...@@ -352,6 +352,11 @@ static int mrst_power_up(struct drm_device *dev) ...@@ -352,6 +352,11 @@ static int mrst_power_up(struct drm_device *dev)
} }
const struct psb_ops mrst_chip_ops = { const struct psb_ops mrst_chip_ops = {
.name = "Moorestown",
.accel_2d = 1,
.crtc_helper = &mrst_helper_funcs,
.crtc_funcs = &psb_intel_crtc_funcs,
.output_init = mrst_output_init, .output_init = mrst_output_init,
#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE #ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
......
...@@ -282,6 +282,11 @@ int psb_power_up(struct drm_device *dev) ...@@ -282,6 +282,11 @@ int psb_power_up(struct drm_device *dev)
} }
const struct psb_ops psb_chip_ops = { const struct psb_ops psb_chip_ops = {
.name = "Poulsbo",
.accel_2d = 1,
.crtc_helper = &psb_intel_helper_funcs,
.crtc_funcs = &psb_intel_crtc_funcs,
.output_init = psb_output_init, .output_init = psb_output_init,
#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE #ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
......
...@@ -617,6 +617,13 @@ struct drm_psb_private { ...@@ -617,6 +617,13 @@ struct drm_psb_private {
*/ */
struct psb_ops { struct psb_ops {
const char *name;
unsigned int accel_2d:1;
/* Sub functions */
struct drm_crtc_helper_funcs const *crtc_helper;
struct drm_crtc_funcs const *crtc_funcs;
/* Display management hooks */ /* Display management hooks */
int (*output_init)(struct drm_device *dev); int (*output_init)(struct drm_device *dev);
/* Power management hooks */ /* Power management hooks */
...@@ -759,6 +766,10 @@ extern const struct drm_crtc_helper_funcs mrst_helper_funcs; ...@@ -759,6 +766,10 @@ extern const struct drm_crtc_helper_funcs mrst_helper_funcs;
extern void mrst_lvds_init(struct drm_device *dev, extern void mrst_lvds_init(struct drm_device *dev,
struct psb_intel_mode_device *mode_dev); struct psb_intel_mode_device *mode_dev);
/* psb_intel_display.c */
extern const struct drm_crtc_helper_funcs psb_intel_helper_funcs;
extern const struct drm_crtc_funcs psb_intel_crtc_funcs;
/* psb_intel_lvds.c */ /* psb_intel_lvds.c */
extern void psb_intel_lvds_prepare(struct drm_encoder *encoder); extern void psb_intel_lvds_prepare(struct drm_encoder *encoder);
extern void psb_intel_lvds_commit(struct drm_encoder *encoder); extern void psb_intel_lvds_commit(struct drm_encoder *encoder);
......
...@@ -211,7 +211,7 @@ static int psbfb_ioctl(struct fb_info *info, unsigned int cmd, ...@@ -211,7 +211,7 @@ static int psbfb_ioctl(struct fb_info *info, unsigned int cmd,
case 0x12345678: case 0x12345678:
if (!capable(CAP_SYS_RAWIO)) if (!capable(CAP_SYS_RAWIO))
return -EPERM; return -EPERM;
if (IS_MFLD(dev)) if (!dev_priv->ops->accel_2d)
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (get_user(l, p)) if (get_user(l, p))
return -EFAULT; return -EFAULT;
...@@ -240,7 +240,7 @@ static struct fb_ops psbfb_ops = { ...@@ -240,7 +240,7 @@ static struct fb_ops psbfb_ops = {
.fb_ioctl = psbfb_ioctl, .fb_ioctl = psbfb_ioctl,
}; };
static struct fb_ops psbfb_mfld_ops = { static struct fb_ops psbfb_unaccel_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.fb_check_var = drm_fb_helper_check_var, .fb_check_var = drm_fb_helper_check_var,
.fb_set_par = drm_fb_helper_set_par, .fb_set_par = drm_fb_helper_set_par,
...@@ -426,8 +426,8 @@ static int psbfb_create(struct psb_fbdev *fbdev, ...@@ -426,8 +426,8 @@ static int psbfb_create(struct psb_fbdev *fbdev,
info->flags = FBINFO_DEFAULT; info->flags = FBINFO_DEFAULT;
/* No 2D engine */ /* No 2D engine */
if (IS_MFLD(dev)) if (!dev_priv->ops->accel_2d)
info->fbops = &psbfb_mfld_ops; info->fbops = &psbfb_unaccel_ops;
else else
info->fbops = &psbfb_ops; info->fbops = &psbfb_ops;
......
...@@ -1260,7 +1260,7 @@ void psb_intel_crtc_destroy(struct drm_crtc *crtc) ...@@ -1260,7 +1260,7 @@ void psb_intel_crtc_destroy(struct drm_crtc *crtc)
kfree(psb_intel_crtc); kfree(psb_intel_crtc);
} }
static const struct drm_crtc_helper_funcs psb_intel_helper_funcs = { const struct drm_crtc_helper_funcs psb_intel_helper_funcs = {
.dpms = psb_intel_crtc_dpms, .dpms = psb_intel_crtc_dpms,
.mode_fixup = psb_intel_crtc_mode_fixup, .mode_fixup = psb_intel_crtc_mode_fixup,
.mode_set = psb_intel_crtc_mode_set, .mode_set = psb_intel_crtc_mode_set,
...@@ -1304,12 +1304,8 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe, ...@@ -1304,12 +1304,8 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe,
return; return;
} }
if (IS_MFLD(dev)) /* Set the CRTC operations from the chip specific data */
drm_crtc_init(dev, &psb_intel_crtc->base, drm_crtc_init(dev, &psb_intel_crtc->base, dev_priv->ops->crtc_funcs);
&mdfld_intel_crtc_funcs);
else
drm_crtc_init(dev, &psb_intel_crtc->base,
&psb_intel_crtc_funcs);
drm_mode_crtc_set_gamma_size(&psb_intel_crtc->base, 256); drm_mode_crtc_set_gamma_size(&psb_intel_crtc->base, 256);
psb_intel_crtc->pipe = pipe; psb_intel_crtc->pipe = pipe;
...@@ -1332,15 +1328,8 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe, ...@@ -1332,15 +1328,8 @@ void psb_intel_crtc_init(struct drm_device *dev, int pipe,
psb_intel_crtc->mode_dev = mode_dev; psb_intel_crtc->mode_dev = mode_dev;
psb_intel_crtc->cursor_addr = 0; psb_intel_crtc->cursor_addr = 0;
if (IS_MRST(dev)) drm_crtc_helper_add(&psb_intel_crtc->base,
drm_crtc_helper_add(&psb_intel_crtc->base, dev_priv->ops->crtc_helper);
&mrst_helper_funcs);
else if (IS_MFLD(dev))
drm_crtc_helper_add(&psb_intel_crtc->base,
&mdfld_helper_funcs);
else
drm_crtc_helper_add(&psb_intel_crtc->base,
&psb_intel_helper_funcs);
/* Setup the array of drm_connector pointer array */ /* Setup the array of drm_connector pointer array */
psb_intel_crtc->mode_set.crtc = &psb_intel_crtc->base; psb_intel_crtc->mode_set.crtc = &psb_intel_crtc->base;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment